Paths

Table of Contentst

Differential D13149

[lib] move generating P2P messages to `useProcessDMOperation`
ClosedPublic
Actions

Authored by kamil on Fri, Aug 23, 5:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 17, 2:08 AM

	Unknown Object (File)
	Thu, Sep 12, 1:02 AM

	Unknown Object (File)
	Thu, Sep 12, 12:24 AM

	Unknown Object (File)
	Fri, Sep 6, 12:59 PM

	Unknown Object (File)
	Fri, Sep 6, 11:29 AM

	Unknown Object (File)
	Thu, Sep 5, 7:21 AM

	Unknown Object (File)
	Wed, Sep 4, 8:28 PM

	Unknown Object (File)
	Wed, Sep 4, 7:52 AM

View All 24 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMMab0495fd1d1b: [lib] move generating P2P messages to `useProcessDMOperation`

Summary

We need to process DM Operations and save OutboundP2PMessages in DB in the same SQL transaction to handle cases when the app crashes after applying changes to our store and before addressing messages to other peers - this is inconsistency from which we're unable to heal.

The existing place of generating messages is removed later in the stack.

Depends on D13148

Test Plan

Check that messages are persisted along with changes to store.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Fri, Aug 23, 5:10 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Aug 23, 5:10 AM

kamil added a child revision: D13150: [lib] update `processOutboundP2PMessages` to return IDs of messages queued on Tunnelbroker.Fri, Aug 23, 5:13 AM

Harbormaster completed remote builds in B31233: Diff 43606.Fri, Aug 23, 5:26 AM

kamil published this revision for review.Fri, Aug 23, 7:24 AM

tomek accepted this revision.Mon, Aug 26, 3:10 AM

This revision is now accepted and ready to land.Mon, Aug 26, 3:10 AM

Closed by commit rCOMMab0495fd1d1b: [lib] move generating P2P messages to `useProcessDMOperation` (authored by kamil). · Explain WhyMon, Aug 26, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMab0495fd1d1b: [lib] move generating P2P messages to `useProcessDMOperation`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

process-dm-ops.js

31 lines

Diff 43606

lib/shared/dm-ops/process-dm-ops.js

Loading...