Page MenuHomePhabricator

[lib] move generating P2P messages to `useProcessDMOperation`
ClosedPublic

Authored by kamil on Aug 23 2024, 5:10 AM.
Tags
None
Referenced Files
F3195641: D13149.id.diff
Sat, Nov 9, 3:35 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Wed, Oct 30, 11:31 PM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Thu, Oct 24, 4:57 AM
Unknown Object (File)
Wed, Oct 23, 8:46 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Subscribers

Details

Summary

ENG-8423.

We need to process DM Operations and save OutboundP2PMessages in DB in the same SQL transaction to handle cases when the app crashes after applying changes to our store and before addressing messages to other peers - this is inconsistency from which we're unable to heal.

The existing place of generating messages is removed later in the stack.

Depends on D13148

Test Plan

Check that messages are persisted along with changes to store.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable