Page MenuHomePhabricator
Differential D13935

[native] implement creating User Keys backup
ClosedPublic
Actions

Authored by kamil on Nov 14 2024, 8:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 9:08 AM
Unknown Object (File)
Thu, Apr 3, 4:35 AM
Unknown Object (File)
Thu, Apr 3, 2:13 AM
Unknown Object (File)
Wed, Apr 2, 7:02 PM
Unknown Object (File)
Wed, Apr 2, 10:20 AM
Unknown Object (File)
Mar 23 2025, 12:58 PM
Unknown Object (File)
Mar 14 2025, 5:26 AM
Unknown Object (File)
Mar 14 2025, 3:28 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMdd0cfbe78f8f: [native] implement creating User Keys backup
Summary

ENG-9656.

Adding method in useBackupClient and ability to test uploading User Keys.

Depends on D13934

Test Plan

Tested in D13937

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
backup/
13 lines
profile/
28 lines

Diff 46013

View Options

native/backup/use-client-backup.js

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Lines () => ({
sessionID, sessionID,
}, },
}, },
}), }),
[preRequestUserInfo, keyserverID, cookie, sessionID], [preRequestUserInfo, keyserverID, cookie, sessionID],
); );
// We only need to do a "spot check" on this value below. // We only need to do a "spot check" on this value below.
// - To avoid regenerating performRecovery whenever it changes, we want to // - To avoid regenerating below callbacks whenever it changes, we want to
// make sure it's not in that function's dep list. // make sure it's not in those callbacks' dep lists.
// - If we exclude it from that function's dep list, we'll end up binding in // - If we exclude it from those callbacks' dep lists, we'll end up binding in
// the value of preRequestUserState at the time performRecovery is updated. // the value of preRequestUserState at the time the callbacks are updated.
// Instead, by assigning to a ref, we are able to use the latest value. // Instead, by assigning to a ref, we are able to use the latest value.
const preRequestUserStateRef = React.useRef(preRequestUserState); const preRequestUserStateRef = React.useRef(preRequestUserState);
preRequestUserStateRef.current = preRequestUserState; preRequestUserStateRef.current = preRequestUserState;
const dispatch = useDispatch(); const dispatch = useDispatch();
const urlPrefix = useSelector(urlPrefixSelector(keyserverID)); const urlPrefix = useSelector(urlPrefixSelector(keyserverID));
const logOut = useLogOut(); const logOut = useLogOut();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const invalidateKeyserverSession = React.useCallback( const invalidateKeyserverSession = React.useCallback(
( (
source: RecoveryActionSource, source: RecoveryActionSource,
sessionChange: ClientSessionChange, sessionChange: ClientSessionChange,
userStateBeforeRecovery: PreRequestUserState,
hasBeenCancelled: () => boolean, hasBeenCancelled: () => boolean,
) => { ) => {
if (hasBeenCancelled()) { if (hasBeenCancelled()) {
return; return;
} }
setNewSession( setNewSession(
dispatch, dispatch,
sessionChange, sessionChange,
userStateBeforeRecovery, preRequestUserStateRef.current,
null, null,
source, source,
keyserverID, keyserverID,
); );
if ( if (
keyserverID === authoritativeKeyserverID() && keyserverID === authoritativeKeyserverID() &&
relyingOnAuthoritativeKeyserver relyingOnAuthoritativeKeyserver
) { ) {
Show All 30 Lines ) => {
); );
const sessionChange = const sessionChange =
recoverySessionChange ?? genericCookieInvalidation; recoverySessionChange ?? genericCookieInvalidation;
if ( if (
sessionChange.cookieInvalidated || sessionChange.cookieInvalidated ||
!sessionChange.cookie || !sessionChange.cookie ||
!sessionChange.cookie.startsWith('user=') !sessionChange.cookie.startsWith('user=')
) { ) {
invalidateKeyserverSession( invalidateKeyserverSession(source, sessionChange, hasBeenCancelled);
source,
sessionChange,
userStateBeforeRecovery,
hasBeenCancelled,
);
} }
} catch (e) { } catch (e) {
if (hasBeenCancelled()) { if (hasBeenCancelled()) {
return; return;
} }
console.log( console.log(
`Error during recovery login with keyserver ${keyserverID}`, `Error during recovery login with keyserver ${keyserverID}`,
e, e,
); );
invalidateKeyserverSession( invalidateKeyserverSession(
source, source,
genericCookieInvalidation, genericCookieInvalidation,
userStateBeforeRecovery,
hasBeenCancelled, hasBeenCancelled,
); );
throw e; throw e;
} }
}, },
[keyserverID, dispatch, cookie, urlPrefix, invalidateKeyserverSession], [keyserverID, dispatch, cookie, urlPrefix, invalidateKeyserverSession],
); );
} }
export { export {
canResolveKeyserverSessionInvalidation, canResolveKeyserverSessionInvalidation,
resolveKeyserverSessionInvalidation, resolveKeyserverSessionInvalidation,
useKeyserverRecoveryLogIn, useKeyserverRecoveryLogIn,
}; };
View Options

native/profile/backup-menu.react.js

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Lines () => ({
sessionID, sessionID,
}, },
}, },
}), }),
[preRequestUserInfo, keyserverID, cookie, sessionID], [preRequestUserInfo, keyserverID, cookie, sessionID],
); );
// We only need to do a "spot check" on this value below. // We only need to do a "spot check" on this value below.
// - To avoid regenerating performRecovery whenever it changes, we want to // - To avoid regenerating below callbacks whenever it changes, we want to
// make sure it's not in that function's dep list. // make sure it's not in those callbacks' dep lists.
// - If we exclude it from that function's dep list, we'll end up binding in // - If we exclude it from those callbacks' dep lists, we'll end up binding in
// the value of preRequestUserState at the time performRecovery is updated. // the value of preRequestUserState at the time the callbacks are updated.
// Instead, by assigning to a ref, we are able to use the latest value. // Instead, by assigning to a ref, we are able to use the latest value.
const preRequestUserStateRef = React.useRef(preRequestUserState); const preRequestUserStateRef = React.useRef(preRequestUserState);
preRequestUserStateRef.current = preRequestUserState; preRequestUserStateRef.current = preRequestUserState;
const dispatch = useDispatch(); const dispatch = useDispatch();
const urlPrefix = useSelector(urlPrefixSelector(keyserverID)); const urlPrefix = useSelector(urlPrefixSelector(keyserverID));
const logOut = useLogOut(); const logOut = useLogOut();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const invalidateKeyserverSession = React.useCallback( const invalidateKeyserverSession = React.useCallback(
( (
source: RecoveryActionSource, source: RecoveryActionSource,
sessionChange: ClientSessionChange, sessionChange: ClientSessionChange,
userStateBeforeRecovery: PreRequestUserState,
hasBeenCancelled: () => boolean, hasBeenCancelled: () => boolean,
) => { ) => {
if (hasBeenCancelled()) { if (hasBeenCancelled()) {
return; return;
} }
setNewSession( setNewSession(
dispatch, dispatch,
sessionChange, sessionChange,
userStateBeforeRecovery, preRequestUserStateRef.current,
null, null,
source, source,
keyserverID, keyserverID,
); );
if ( if (
keyserverID === authoritativeKeyserverID() && keyserverID === authoritativeKeyserverID() &&
relyingOnAuthoritativeKeyserver relyingOnAuthoritativeKeyserver
) { ) {
Show All 30 Lines ) => {
); );
const sessionChange = const sessionChange =
recoverySessionChange ?? genericCookieInvalidation; recoverySessionChange ?? genericCookieInvalidation;
if ( if (
sessionChange.cookieInvalidated || sessionChange.cookieInvalidated ||
!sessionChange.cookie || !sessionChange.cookie ||
!sessionChange.cookie.startsWith('user=') !sessionChange.cookie.startsWith('user=')
) { ) {
invalidateKeyserverSession( invalidateKeyserverSession(source, sessionChange, hasBeenCancelled);
source,
sessionChange,
userStateBeforeRecovery,
hasBeenCancelled,
);
} }
} catch (e) { } catch (e) {
if (hasBeenCancelled()) { if (hasBeenCancelled()) {
return; return;
} }
console.log( console.log(
`Error during recovery login with keyserver ${keyserverID}`, `Error during recovery login with keyserver ${keyserverID}`,
e, e,
); );
invalidateKeyserverSession( invalidateKeyserverSession(
source, source,
genericCookieInvalidation, genericCookieInvalidation,
userStateBeforeRecovery,
hasBeenCancelled, hasBeenCancelled,
); );
throw e; throw e;
} }
}, },
[keyserverID, dispatch, cookie, urlPrefix, invalidateKeyserverSession], [keyserverID, dispatch, cookie, urlPrefix, invalidateKeyserverSession],
); );
} }
export { export {
canResolveKeyserverSessionInvalidation, canResolveKeyserverSessionInvalidation,
resolveKeyserverSessionInvalidation, resolveKeyserverSessionInvalidation,
useKeyserverRecoveryLogIn, useKeyserverRecoveryLogIn,
}; };