Page MenuHomePhabricator
Differential D14002

[CommCoreModule] avoid calling Backup Service to get backup secrets
Needs ReviewPublic
Actions

Authored by kamil on Fri, Nov 22, 2:23 AM.
Tags
None
Referenced Files
F3345731: D14002.id45942.diff
Fri, Nov 22, 6:45 AM
F3345730: D14002.id45939.diff
Fri, Nov 22, 6:45 AM
F3345691: D14002.id.diff
Fri, Nov 22, 6:45 AM
F3345663: D14002.diff
Fri, Nov 22, 6:42 AM
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

Part of ENG-9656

It was identified in https://phab.comm.dev/D13849#387643.

We don't need to call the Backup Service, we have the data locally.

retrieveBackupKeys will be refactored later in the stack and used in the Restore protocol to fetch the User Keys from the backup service.

Depends on D14001

Test Plan

Tested creating backup and secondary device login

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Fri, Nov 22, 2:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 22, 2:23 AM
kamil updated this revision to Diff 45942.Fri, Nov 22, 2:48 AM

rebase

kamil added a child revision: D14003: [native] remove `BackupKeys` and use `QRAuthBackupData`.Fri, Nov 22, 2:52 AM
Harbormaster failed remote builds in B32763: Diff 45939!Fri, Nov 22, 3:01 AM
Harbormaster completed remote builds in B32766: Diff 45942.Fri, Nov 22, 3:22 AM
kamil edited the summary of this revision. (Show Details)Fri, Nov 22, 3:56 AM
kamil added inline comments.Fri, Nov 22, 3:59 AM
native/profile/secondary-device-qr-code-scanner.react.js
180–182 ↗(On Diff #45942)

Previously we had validation because we received a string, which was downloaded from the Blob service and decrypted. Right now we have a JSI object so there is need to validate this.

kamil published this revision for review.Fri, Nov 22, 4:00 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
68 lines
_generated/
profile/
24 lines
schema/
7 lines

Diff 45939

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...