Paths

Table of Contentst

Differential D14003

[native] remove `BackupKeys` and use `QRAuthBackupData`
ClosedPublic
Actions

Authored by kamil on Nov 22 2024, 2:52 AM.

Tags

None

Referenced Files

	F3524906: D14003.id45943.diff
	Mon, Dec 23, 3:04 PM

	F3521256: D14003.id.diff
	Mon, Dec 23, 2:46 AM

	Unknown Object (File)
	Fri, Dec 20, 9:25 PM

	Unknown Object (File)
	Tue, Dec 17, 8:55 PM

	Unknown Object (File)
	Sat, Dec 14, 11:36 PM

	Unknown Object (File)
	Sun, Dec 8, 7:22 PM

	Unknown Object (File)
	Sun, Dec 8, 5:23 AM

	Unknown Object (File)
	Fri, Dec 6, 7:00 PM

View All 17 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM9518c5eb72a4: [native] remove `BackupKeys` and use `QRAuthBackupData`

Summary

Part of ENG-9656

BackupKeys can be misleading and confused with actual Use Keys; additionally, it also contains backupID. This was duplicated with the QRAuthBackupData type, which is the same type, but it's more suitable as it's going to be used only in the context of the Secondary Device Login protocol.

Additionally renaming retrieveBackupKeys -> getQRAuthBackupData

Depends on D14002

Test Plan

Tested creating backup and secondary device login

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 22 2024, 2:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 22 2024, 2:52 AM

kamil added a child revision: D14004: [backup-client][native] refactor restoring logic and deprecate `restoreBackup`.Nov 22 2024, 2:56 AM

kamil added a parent revision: D13968: [native] avoid showing SIWE backup message screen for non-primary devices.Nov 22 2024, 2:56 AM

Harbormaster completed remote builds in B32767: Diff 45943.Nov 22 2024, 3:31 AM

kamil published this revision for review.Nov 22 2024, 3:59 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.

native/native_rust_library/src/backup.rs
498–505 ↗	(On Diff #45943)	This is removed in the next diff

bartek accepted this revision.Tue, Nov 26, 1:50 AM

This revision is now accepted and ready to land.Tue, Nov 26, 1:50 AM

Closed by commit rCOMM9518c5eb72a4: [native] remove `BackupKeys` and use `QRAuthBackupData` (authored by kamil). · Explain WhyTue, Dec 3, 6:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9518c5eb72a4: [native] remove `BackupKeys` and use `QRAuthBackupData`.

Revision Contents
Changeset List

Path

Size

lib/

components/

qr-auth-provider.react.js

4 lines

types/

backup-types.js

13 lines

tunnelbroker/

qr-code-auth-message-types.js

2 lines

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

2 lines

CommCoreModule.cpp

2 lines

_generated/

commJSI-generated.cpp

native_rust_library/

src/

1 line

profile/

secondary-device-qr-code-scanner.react.js

2 lines

schema/

CommCoreModuleSchema.js

6 lines

utils/

qr-code-utils.js

8 lines

Diff 46189

lib/components/qr-auth-provider.react.js

Loading...

lib/types/backup-types.js

Loading...

lib/types/tunnelbroker/qr-code-auth-message-types.js

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/native_rust_library/src/backup.rs

Loading...

native/profile/secondary-device-qr-code-scanner.react.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

native/utils/qr-code-utils.js

Loading...