Page MenuHomePhabricator
Differential D14065

[native] regenerate backup on every password change
ClosedPublic
Actions

Authored by kamil on Nov 28 2024, 6:23 AM.
Tags
None
Referenced Files
F6198057: D14065.id46109.diff
Wed, Apr 23, 4:15 PM
F6191966: D14065.id46205.diff
Wed, Apr 23, 1:09 PM
F6189801: D14065.id46181.diff
Wed, Apr 23, 12:19 PM
F6183302: D14065.id46186.diff
Wed, Apr 23, 8:52 AM
Unknown Object (File)
Wed, Apr 23, 2:34 AM
Unknown Object (File)
Mon, Apr 21, 9:44 PM
Unknown Object (File)
Mar 20 2025, 9:28 AM
Unknown Object (File)
Mar 5 2025, 8:29 PM
View All 62 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM863c17c11b6c: [native] regenerate backup on every password change
Summary

ENG-8070

Some concerns are listed the comment in ENG-8070.

Depends on D14063

Test Plan

On primary device, change password and check that new backup was uploaded

Diff Detail

Repository
rCOMM Comm
Branch
backup-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Nov 28 2024, 6:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2024, 6:23 AM
kamil edited the summary of this revision. (Show Details)Nov 28 2024, 6:25 AM
kamil added inline comments.
native/backup/backup-handler.js
149

This should be added to diff earlier in the stack, I am going to fix this in next rebase

Harbormaster completed remote builds in B32893: Diff 46109.Nov 28 2024, 6:41 AM
kamil published this revision for review.Nov 28 2024, 9:10 AM
bartek accepted this revision.Dec 3 2024, 12:29 AM
This revision is now accepted and ready to land.Dec 3 2024, 12:29 AM
kamil updated this revision to Diff 46181.Dec 3 2024, 4:24 AM

rebase before landing

Harbormaster failed remote builds in B32920: Diff 46181!Dec 3 2024, 4:38 AM
kamil updated this revision to Diff 46186.Dec 3 2024, 5:31 AM

rebase before landing v2

Harbormaster completed remote builds in B32922: Diff 46186.Dec 3 2024, 5:58 AM
Closed by commit rCOMM863c17c11b6c: [native] regenerate backup on every password change (authored by kamil). · Explain WhyDec 3 2024, 6:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM863c17c11b6c: [native] regenerate backup on every password change.

Revision Contents
Changeset List

PathSize
lib/
reducers/
5 lines
native/
backup/
1 line

Diff 46109

View Options

lib/reducers/backup-reducer.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });
View Options

native/backup/backup-handler.js

// @flow // @flow
import reduceKeyserverStore from './keyserver-reducer.js'; import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js'; import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { import { defaultKeyserverInfo } from '../types/keyserver-types.js';
defaultKeyserverInfo,
type KeyserverStore,
} from '../types/keyserver-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
jest.mock('../utils/config.js'); jest.mock('../utils/config.js');
describe('reduceKeyserverStore', () => { describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => { it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = { const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
Show All 25 Lines it('removes from the store keyservers the user has disconnected from', () => {
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore, .keyserverStore,
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } }); ).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
}); });
it('update keyserverInfo with authoritativeKeyserverID', () => { it('update keyserverInfo with authoritativeKeyserverID', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 14 Lines expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual(null); ).toEqual(null);
}); });
it('return the same keyserverInfo with authoritativeKeyserverID()', () => { it('return the same keyserverInfo with authoritativeKeyserverID()', () => {
const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1'); const defaultAshoatKeyserverInfo = defaultKeyserverInfo('url1');
const oldKeyserverStore: KeyserverStore = ({ const oldKeyserverStore = {
keyserverInfos: { keyserverInfos: {
[authoritativeKeyserverID()]: { [authoritativeKeyserverID()]: {
...defaultAshoatKeyserverInfo, ...defaultAshoatKeyserverInfo,
connection: { connection: {
...defaultAshoatKeyserverInfo.connection, ...defaultAshoatKeyserverInfo.connection,
connectionIssue: 'blah', connectionIssue: 'client_version_unsupported',
}, },
}, },
}, },
}: any); };
const deleteAccountAction = { const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success, type: deleteKeyserverAccountActionTypes.success,
payload: { payload: {
currentUserInfo: { anonymous: true }, currentUserInfo: { anonymous: true },
preRequestUserState: { preRequestUserState: {
cookiesAndSessions: {}, cookiesAndSessions: {},
currentUserInfo: { currentUserInfo: {
Show All 9 Lines const deleteAccountAction = {
customKeyName: undefined, customKeyName: undefined,
}, },
}; };
expect( expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction) reduceKeyserverStore(oldKeyserverStore, deleteAccountAction)
.keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection .keyserverStore.keyserverInfos[authoritativeKeyserverID()].connection
.connectionIssue, .connectionIssue,
).toEqual('blah'); ).toEqual('client_version_unsupported');
}); });
}); });