Page MenuHomePhabricator

[lib] Avoid unnecessary useSelector on MessageStore in useGetLastUpdatedTimes
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:45 PM.
Tags
None
Referenced Files
F3513783: D14137.diff
Sun, Dec 22, 2:04 AM
Unknown Object (File)
Fri, Dec 20, 12:59 AM
Unknown Object (File)
Wed, Dec 18, 11:12 AM
Unknown Object (File)
Wed, Dec 18, 9:42 AM
Unknown Object (File)
Tue, Dec 17, 6:29 PM
Unknown Object (File)
Tue, Dec 17, 11:52 AM
Unknown Object (File)
Sun, Dec 15, 7:56 PM
Subscribers
None

Details

Summary

I noticed we're putting a useSelector on MessageStore twice here... this is a minor cleanup.

Depends on D14136

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage