[lib] Extract thread hooks to a separate file
ClosedPublic
Actions

Authored by tomek on Apr 29 2025, 5:17 PM.

Details

Reviewers

kamil
angelika

Commits

rCOMM3a9c4fe603e5: [lib] Extract thread hooks to a separate file

Summary

This avoids a circular dependency in the next diff.

Depends on D14622

Test Plan

Flow.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 29 2025, 5:17 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2025, 5:17 PM

tomek added a child revision: D14624: [lib] Move adding thread members to a spec.Apr 29 2025, 5:19 PM

Harbormaster completed remote builds in B34051: Diff 47905.Apr 29 2025, 5:35 PM

tomek requested review of this revision.Apr 29 2025, 5:35 PM

angelika accepted this revision.May 5 2025, 12:40 PM

angelika added inline comments.

lib/actions/thread-actions.js
57 ↗	(On Diff #47905)	since there are just action types left, maybe we should rename this file to "thread-action-types.js"?

This revision is now accepted and ready to land.May 5 2025, 12:40 PM

tomek added inline comments.May 8 2025, 3:19 PM

lib/actions/thread-actions.js
57 ↗	(On Diff #47905)	Good idea! Renamed in a new diff D14664 to avoid conflicts.

Closed by commit rCOMM3a9c4fe603e5: [lib] Extract thread hooks to a separate file. · Explain WhyMay 9 2025, 12:32 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM3a9c4fe603e5: [lib] Extract thread hooks to a separate file.

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

441 lines

components/

base-edit-thread-avatar-provider.react.js

6 lines

hooks/

promote-sidebar.react.js

6 lines

thread-hooks.js

435 lines

shared/

community-utils.js

6 lines

messages/

text-message-spec.js

6 lines

thread-actions-utils.js

2 lines

threads/

thread-spec.js

2 lines

native/

chat/

chat-input-bar.react.js

2 lines

compose-subchannel.react.js

6 lines

settings/

add-users-modal.react.js

6 lines

color-selector-modal.react.js

8 lines

delete-thread.react.js

8 lines

thread-settings-description.react.js

8 lines

thread-settings-leave-thread.react.js

8 lines

thread-settings-media-gallery.react.js

2 lines

thread-settings-member-tooltip-modal.react.js

2 lines

thread-settings-name.react.js

8 lines

community-creation/

community-configuration.react.js

6 lines

components/

community-list-item.react.js

6 lines

input/

input-state-container.react.js

3 lines

roles/

change-roles-header-right-button.react.js

6 lines

create-roles-header-right-button.react.js

6 lines

role-utils.react.js

6 lines

web/

chat/

chat-input-bar.react.js

4 lines

thread-menu.react.js

6 lines

input/

input-state-container.react.js

3 lines

modals/

threads/

create/

compose-subchannel-modal.react.js

6 lines

gallery/

thread-settings-media-gallery.react.js

2 lines

members/

add-members-modal.react.js

6 lines

change-member-role-modal.react.js

6 lines

member.react.js

2 lines

settings/

thread-settings-utils.js

6 lines

roles/

create-roles-modal.react.js

6 lines

delete-role-modal.react.js

6 lines

sidebar/

community-creation/

community-creation-modal.react.js

6 lines

Diff 48016

View Options

lib/actions/thread-actions.js

View Options

lib/components/base-edit-thread-avatar-provider.react.js

View Options

lib/hooks/promote-sidebar.react.js

View Options

lib/hooks/thread-hooks.js

View Options

lib/shared/community-utils.js

View Options

lib/shared/messages/text-message-spec.js

View Options

lib/shared/thread-actions-utils.js

View Options

lib/shared/threads/thread-spec.js

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/compose-subchannel.react.js

View Options

native/chat/settings/add-users-modal.react.js

View Options

native/chat/settings/color-selector-modal.react.js

View Options

native/chat/settings/delete-thread.react.js

View Options

native/chat/settings/thread-settings-description.react.js

View Options

native/chat/settings/thread-settings-leave-thread.react.js

View Options

native/chat/settings/thread-settings-media-gallery.react.js

View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

View Options

native/chat/settings/thread-settings-name.react.js

View Options

native/community-creation/community-configuration.react.js

View Options

native/components/community-list-item.react.js

View Options

native/input/input-state-container.react.js

View Options

native/roles/change-roles-header-right-button.react.js

View Options

native/roles/create-roles-header-right-button.react.js

View Options

native/roles/role-utils.react.js

View Options

web/chat/chat-input-bar.react.js

View Options

web/chat/thread-menu.react.js

View Options

web/input/input-state-container.react.js

View Options

web/modals/threads/create/compose-subchannel-modal.react.js

View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

View Options

web/modals/threads/members/add-members-modal.react.js

View Options

web/modals/threads/members/change-member-role-modal.react.js

View Options

web/modals/threads/members/member.react.js

View Options

web/modals/threads/settings/thread-settings-utils.js

View Options

web/roles/create-roles-modal.react.js

View Options

web/roles/delete-role-modal.react.js

View Options

web/sidebar/community-creation/community-creation-modal.react.js

[lib] Extract thread hooks to a separate fileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48016

lib/actions/thread-actions.js

lib/components/base-edit-thread-avatar-provider.react.js

lib/hooks/promote-sidebar.react.js

lib/hooks/thread-hooks.js

lib/shared/community-utils.js

lib/shared/messages/text-message-spec.js

lib/shared/thread-actions-utils.js

lib/shared/threads/thread-spec.js

native/chat/chat-input-bar.react.js

native/chat/compose-subchannel.react.js

native/chat/settings/add-users-modal.react.js

native/chat/settings/color-selector-modal.react.js

native/chat/settings/delete-thread.react.js

native/chat/settings/thread-settings-description.react.js

native/chat/settings/thread-settings-leave-thread.react.js

native/chat/settings/thread-settings-media-gallery.react.js

native/chat/settings/thread-settings-member-tooltip-modal.react.js

native/chat/settings/thread-settings-name.react.js

native/community-creation/community-configuration.react.js

native/components/community-list-item.react.js

native/input/input-state-container.react.js

native/roles/change-roles-header-right-button.react.js

native/roles/create-roles-header-right-button.react.js

native/roles/role-utils.react.js

web/chat/chat-input-bar.react.js

web/chat/thread-menu.react.js

web/input/input-state-container.react.js

web/modals/threads/create/compose-subchannel-modal.react.js

web/modals/threads/gallery/thread-settings-media-gallery.react.js

web/modals/threads/members/add-members-modal.react.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/settings/thread-settings-utils.js

web/roles/create-roles-modal.react.js

web/roles/delete-role-modal.react.js

web/sidebar/community-creation/community-creation-modal.react.js

[lib] Extract thread hooks to a separate file
ClosedPublic
Actions

Revision Contents
Changeset List