Paths

Table of Contentst

Differential D14772

[native] add `latestDatabaseVersion` to `BackupStore`
ClosedPublic
Actions

Authored by kamil on May 27 2025, 1:45 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM85937827bbd2: [native] add `latestDatabaseVersion` to `BackupStore`

Summary

Part of ENG-7014

We need it to detect that database schema changed, and we should trigger compaction. This field should be set when uploading User Data.

Added migration to fill this field on native.

Depends on D14770

Test Plan

Flow, test migration

Diff Detail

Repository

Branch

publish-6

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 27 2025, 1:45 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 27 2025, 1:45 PM

Harbormaster failed remote builds in B34284: Diff 48280!May 27 2025, 1:55 PM

kamil added a child revision: D14773: [native] trigger User Data upload after schema change.May 27 2025, 1:56 PM

Harbormaster completed remote builds in B34284: Diff 48280.May 27 2025, 2:31 PM

kamil published this revision for review.May 27 2025, 3:20 PM

kamil added inline comments.May 28 2025, 3:32 PM

lib/types/backup-types.js
82	I just realized this should be optional, because currently we don't upload User Data, so we shouldn't set this field, it should only be set when the database is actually uploaded. I think because of that we can remove migrations

make latestDatabaseVersion optional

Harbormaster completed remote builds in B34310: Diff 48327.May 28 2025, 4:49 PM

bartek accepted this revision.May 30 2025, 7:08 AM

This revision is now accepted and ready to land.May 30 2025, 7:08 AM

Closed by commit rCOMM85937827bbd2: [native] add `latestDatabaseVersion` to `BackupStore`. · Explain WhyJun 2 2025, 10:40 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM85937827bbd2: [native] add `latestDatabaseVersion` to `BackupStore`.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

backup-reducer.js

2 lines

types/

backup-types.js

1 line

native/

redux/

default-state.js

1 line

persist-constants.js

2 lines

15 lines

web/

redux/

persist-constants.js

2 lines

4 lines

Diff 48280

lib/reducers/backup-reducer.js

Loading...

lib/types/backup-types.js

Loading...

native/redux/default-state.js

Loading...

native/redux/persist-constants.js

Loading...

native/redux/persist.js

Loading...

web/redux/persist-constants.js

Loading...

web/redux/persist.js

Loading...