Page MenuHomePhabricator
Differential D5003

[services] Backup - Add tools for blob client
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 7:55 PM
Unknown Object (File)
Thu, Sep 26, 7:55 PM
Unknown Object (File)
Thu, Sep 26, 7:54 PM
Unknown Object (File)
Thu, Sep 26, 7:54 PM
Unknown Object (File)
Thu, Sep 26, 7:54 PM
Unknown Object (File)
Thu, Sep 26, 7:47 PM
Unknown Object (File)
Tue, Sep 10, 11:27 PM
Unknown Object (File)
Wed, Sep 4, 4:47 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
Commits
rCOMM5e99a40b0379: [services] Backup - Add tools for blob client
Summary

Depends on D5002

These tools will be helpful for communication between rust and c++

Test Plan

backup builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 4:05 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:05 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B11760: Diff 16163.Sep 1 2022, 4:16 AM
• karol requested review of this revision.Sep 1 2022, 4:16 AM
• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:16 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5002: [services] Backup - Tests - Pull Backup - Improve logging.
• karol added a child revision: D5004: [services] Backup - Blob Put Client - Update put API.
• jon added a comment.Sep 1 2022, 8:38 AM

This looks like a "wire" field. Shouldn't this go into a proto if it's going to be part of the messaging protocol?

• karol added a comment.Sep 2 2022, 5:32 AM

You're right, we can use a field from the files generated by the protobuf

• karol planned changes to this revision.Sep 2 2022, 5:32 AM
• karol updated this revision to Diff 16241.Sep 2 2022, 5:35 AM

address feedback

Harbormaster completed remote builds in B11836: Diff 16241.Sep 2 2022, 5:44 AM
tomek accepted this revision.Sep 5 2022, 2:09 AM
This revision is now accepted and ready to land.Sep 5 2022, 2:09 AM
• karol updated this revision to Diff 16435.Sep 8 2022, 3:56 AM

rebase

Harbormaster completed remote builds in B11980: Diff 16435.Sep 8 2022, 4:06 AM
Closed by commit rCOMM5e99a40b0379: [services] Backup - Add tools for blob client (authored by • karol). · Explain WhySep 8 2022, 4:09 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM5e99a40b0379: [services] Backup - Add tools for blob client.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
6 lines
14 lines

Diff 16435

View Options

services/backup/src/Tools.h

Loading...
View Options

services/backup/src/Tools.cpp

Loading...