[services] Backup - Add tools for blob client
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:05 AM.

Details

Reviewers

• jon
tomek
• max

Commits

rCOMM5e99a40b0379: [services] Backup - Add tools for blob client

Summary

Depends on D5002

These tools will be helpful for communication between rust and c++

Test Plan

backup builds

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 1 2022, 4:05 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:05 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B11760: Diff 16163.Sep 1 2022, 4:16 AM

• karol requested review of this revision.Sep 1 2022, 4:16 AM

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:16 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D5002: [services] Backup - Tests - Pull Backup - Improve logging.

• karol added a child revision: D5004: [services] Backup - Blob Put Client - Update put API.

This looks like a "wire" field. Shouldn't this go into a proto if it's going to be part of the messaging protocol?

You're right, we can use a field from the files generated by the protobuf

• karol planned changes to this revision.Sep 2 2022, 5:32 AM

address feedback

Harbormaster completed remote builds in B11836: Diff 16241.Sep 2 2022, 5:44 AM

tomek accepted this revision.Sep 5 2022, 2:09 AM

This revision is now accepted and ready to land.Sep 5 2022, 2:09 AM

rebase

Harbormaster completed remote builds in B11980: Diff 16435.Sep 8 2022, 4:06 AM

Closed by commit rCOMM5e99a40b0379: [services] Backup - Add tools for blob client (authored by • karol). · Explain WhySep 8 2022, 4:09 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM5e99a40b0379: [services] Backup - Add tools for blob client.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Tools.h

6 lines

Tools.cpp

14 lines

Diff 16462

View Options

services/backup/src/Tools.h