Differential D5006

[services] Backup - Blob Put Client - Add helper functions
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:06 AM.

Tags

None

Referenced Files

	F32509093: D5006.1767095691.diff
	Mon, Dec 29, 11:54 AM

Subscribers

Details

Reviewers

• jon
tomek
varun
• max

Commits

rCOMMa20c5f282130: [services] Backup - Blob Put Client - Add helper functions

Summary

Depends on D5005

Adding some helper function that will be used by the put client

Test Plan

backup builds

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:06 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:06 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B11763: Diff 16166.Sep 1 2022, 11:17 AM

• karol requested review of this revision.Sep 1 2022, 11:17 AM

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 11:19 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • max.

• karol added a parent revision: D5005: [services] Backup - Blob Put Client - Add essential objects.

• karol added a child revision: D5007: [services] Backup - Blob Put Client - Install async stream.

• jon requested changes to this revision.Sep 1 2022, 3:51 PM

• jon added inline comments.

services/backup/blob_client/src/put_client.rs
46–63	I'm confused as to why we need to collect then later read error messages. We should probably just emit them as they occur, and not deal with this state management. What's the benefit of having to separately manage error messages?

This revision now requires changes to proceed.Sep 1 2022, 3:51 PM

• karol requested review of this revision.Sep 2 2022, 2:05 PM

• karol added inline comments.

services/backup/blob_client/src/put_client.rs
46–63	https://phab.comm.dev/D5005#146417

tomek accepted this revision.Sep 5 2022, 9:35 AM

tomek added inline comments.

services/backup/blob_client/src/put_client.rs
35–44	We can simplify this

• karol added inline comments.Sep 5 2022, 1:53 PM

services/backup/blob_client/src/put_client.rs
35–44	ok

address comment

Harbormaster completed remote builds in B11883: Diff 16315.Sep 5 2022, 2:03 PM

tomek mentioned this in D5013: [services] Backup - Blob Get Client - Add base structure.Sep 7 2022, 12:06 PM

https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

This revision is now accepted and ready to land.Sep 7 2022, 5:38 PM

rebase

Harbormaster completed remote builds in B11983: Diff 16438.Sep 8 2022, 11:07 AM

Closed by commit rCOMMa20c5f282130: [services] Backup - Blob Put Client - Add helper functions. · Explain WhySep 8 2022, 11:10 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMa20c5f282130: [services] Backup - Blob Put Client - Add helper functions.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

30 lines

Diff 16166

services/backup/blob_client/src/put_client.rs

Loading...