Differential D5008

[services] Backup - Blob Put Client - Add address constant
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:07 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

• jon
tomek
• max
varun

Commits

rCOMMa9fbedbf1692: [services] Backup - Blob Put Client - Add address constant

Summary

Depends on D5007

Adding the blob address that's going to be used by the blob client to connect to the blob server

Test Plan

backup builds

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 1 2022, 11:07 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:07 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B11765: Diff 16168.Sep 1 2022, 11:19 AM

• karol requested review of this revision.Sep 1 2022, 11:19 AM

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 11:21 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D5007: [services] Backup - Blob Put Client - Install async stream.

• karol added a child revision: D5009: [services] Backup - Blob Put Client - Add initialize.

• jon requested changes to this revision.Sep 1 2022, 3:44 PM

• jon added inline comments.

services/backup/blob_client/src/constants.rs
2 ↗	(On Diff #16168)	We should have some way to configure this The following should be a valid way to use blob client, or something similar: BLOB_ADDRESS=localhost:3829 ./blob_client

This revision now requires changes to proceed.Sep 1 2022, 3:44 PM

• karol requested review of this revision.Sep 2 2022, 12:53 PM

• karol added inline comments.

services/backup/blob_client/src/constants.rs
2 ↗	(On Diff #16168)	I created a task for this, I think it can be addressed later https://linear.app/comm/issue/ENG-1731/enable-configuring-the-blob-address-from-the-outside

tomek accepted this revision.Sep 5 2022, 9:38 AM

• jon accepted this revision.Sep 7 2022, 5:38 PM

This revision is now accepted and ready to land.Sep 7 2022, 5:38 PM

rebase

Harbormaster completed remote builds in B11985: Diff 16440.Sep 8 2022, 11:09 AM

Closed by commit rCOMMa9fbedbf1692: [services] Backup - Blob Put Client - Add address constant. · Explain WhySep 8 2022, 11:10 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMa9fbedbf1692: [services] Backup - Blob Put Client - Add address constant.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

1 line

Diff 16467

services/backup/blob_client/src/constants.rs

Loading...