services/backup/blob_client/src/get_client.rs
25–26 ↗	(On Diff #16173)	It was mentioned previously, but do we need an `Arc` here?
32–59 ↗	(On Diff #16173)	I've seen somewhere in this stack the code, that was (almost?) exactly the same. Can we avoid the duplication?
services/backup/blob_client/src/lib.rs
26 ↗	(On Diff #16173)	Can we avoid `unsafe` at function level?

This revision now requires changes to proceed.Sep 5 2022, 5:26 AM

• karol requested review of this revision.Sep 6 2022, 1:43 AM

• karol added inline comments.

services/backup/blob_client/src/get_client.rs
25–26 ↗	(On Diff #16173)	https://linear.app/comm/issue/ENG-1732/remove-arc-from-lazy-static
32–59 ↗	(On Diff #16173)	Duplication is avoided in D5030 D5031
services/backup/blob_client/src/lib.rs
26 ↗	(On Diff #16173)	If we want to receive the argument which is `char*` then rust will complain to make the function unsafe explicitly so I do not think so.

remove comment

Harbormaster completed remote builds in B11908: Diff 16351.Sep 6 2022, 1:56 AM

tomek accepted this revision.Sep 7 2022, 5:06 AM

tomek added inline comments.

services/backup/blob_client/src/get_client.rs
32–41 ↗	(On Diff #16351)	I know this is refactored later, but we should use here the same approach as in D5006

This revision is now accepted and ready to land.Sep 7 2022, 5:06 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM

Closed by commit rCOMM77d843164f0b: [services] Backup - Blob Get Client - Add base structure (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM77d843164f0b: [services] Backup - Blob Get Client - Add base structure.

Harbormaster completed remote builds in B11990: Diff 16445.Sep 8 2022, 4:14 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

get_client.rs

72 lines

lib.rs

9 lines

Diff 16445

View Options

services/backup/blob_client/src/get_client.rs

This file was added.

				// Messages sent between tunnelbroker and a device

				use serde::{Deserialize, Serialize};

				/// The workflow when estabilishing a tunnelbroker connection:
				/// - Client sends SessionRequest
				/// - Tunnelbroker validates access_token with identity service
				/// - Tunnelbroker emits an AMQP message declaring that it has opened a new
				/// connection with a given device, so that the respective tunnelbroker
				/// instance can close the existing connection.
				/// - Tunnelbroker returns a session_id representing that the connection was
				/// accepted
				/// - Tunnelbroker will flush all messages related to device from RabbitMQ.
				/// This must be done first before flushing DynamoDB to prevent duplicated
				/// messages.
				/// - Tunnelbroker flushes all messages in DynamoDB
				/// - Tunnelbroker orders messages by creation date (oldest first), and sends
				/// messages to device
				/// - Tunnelbroker then polls for incoming messages from device

				#[derive(Serialize, Deserialize, Debug, PartialEq)]
				#[serde(rename_all = "camelCase")]
				pub enum DeviceTypes {
				Mobile,
				Web,
				Keyserver,
				}

				/// Message sent by a client to tunnelbroker to initiate a websocket
				/// session. Tunnelbroker will then validate the access token with identity
				/// service before continuing with the request.
				#[derive(Serialize, Deserialize)]
				#[serde(tag = "type", rename_all = "camelCase")]
				pub struct SessionRequest {
				pub device_id: String,
				pub access_token: String,
				pub notify_token: Option<String>,
				pub device_type: DeviceTypes,
				pub device_app_version: Option<String>,
				pub device_os: Option<String>,
				}

				#[derive(Serialize, Deserialize)]
				pub struct SessionResponse {
				pub session_id: String,
				}

				#[cfg(test)]
				mod session_tests {
				use super::*;

				#[test]
				fn test_session_deserialization() {
				let example_payload = r#"{
				"type": "sessionRequest",
				"accessToken": "xkdeifjsld",
				"deviceId": "foo",
				"deviceType": "keyserver"
				}"#;

				let request =
				serde_json::from_str::<SessionRequest>(example_payload).unwrap();
				assert_eq!(request.device_id, "foo");
				assert_eq!(request.access_token, "xkdeifjsld");
				assert_eq!(request.device_os, None);
				assert_eq!(request.device_type, DeviceTypes::Keyserver);
				}
				}

View Options

services/backup/blob_client/src/lib.rs

This file was added.

				// Messages sent between tunnelbroker and a device

				use serde::{Deserialize, Serialize};

				/// The workflow when estabilishing a tunnelbroker connection:
				/// - Client sends SessionRequest
				/// - Tunnelbroker validates access_token with identity service
				/// - Tunnelbroker emits an AMQP message declaring that it has opened a new
				/// connection with a given device, so that the respective tunnelbroker
				/// instance can close the existing connection.
				/// - Tunnelbroker returns a session_id representing that the connection was
				/// accepted
				/// - Tunnelbroker will flush all messages related to device from RabbitMQ.
				/// This must be done first before flushing DynamoDB to prevent duplicated
				/// messages.
				/// - Tunnelbroker flushes all messages in DynamoDB
				/// - Tunnelbroker orders messages by creation date (oldest first), and sends
				/// messages to device
				/// - Tunnelbroker then polls for incoming messages from device

				#[derive(Serialize, Deserialize, Debug, PartialEq)]
				#[serde(rename_all = "camelCase")]
				pub enum DeviceTypes {
				Mobile,
				Web,
				Keyserver,
				}

				/// Message sent by a client to tunnelbroker to initiate a websocket
				/// session. Tunnelbroker will then validate the access token with identity
				/// service before continuing with the request.
				#[derive(Serialize, Deserialize)]
				#[serde(tag = "type", rename_all = "camelCase")]
				pub struct SessionRequest {
				pub device_id: String,
				pub access_token: String,
				pub notify_token: Option<String>,
				pub device_type: DeviceTypes,
				pub device_app_version: Option<String>,
				pub device_os: Option<String>,
				}

				#[derive(Serialize, Deserialize)]
				pub struct SessionResponse {
				pub session_id: String,
				}

				#[cfg(test)]
				mod session_tests {
				use super::*;

				#[test]
				fn test_session_deserialization() {
				let example_payload = r#"{
				"type": "sessionRequest",
				"accessToken": "xkdeifjsld",
				"deviceId": "foo",
				"deviceType": "keyserver"
				}"#;

				let request =
				serde_json::from_str::<SessionRequest>(example_payload).unwrap();
				assert_eq!(request.device_id, "foo");
				assert_eq!(request.access_token, "xkdeifjsld");
				assert_eq!(request.device_os, None);
				assert_eq!(request.device_type, DeviceTypes::Keyserver);
				}
				}

[services] Backup - Blob Get Client - Add base structureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16445

services/backup/blob_client/src/get_client.rs

services/backup/blob_client/src/lib.rs

[services] Backup - Blob Get Client - Add base structure
ClosedPublic
Actions

Revision Contents
Changeset List