Depends on D5013
Adding initialize function to the blob get client.
Details
Details
backup builds
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 64–69 | This feels unsafe. What should be the result of is_initialized() after get_client_terminate_cxx? Can we simplify the logic, so that handling repeated initializations is contained within the if and we exit the function there? | |
| 86–88 | We can simplify the code by using loop and break | |
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 64–69 |
false
I wouldn't suppress such an action. Re-initialization was introduced in order to simplify the code in c++, so we don't have to call terminate explicitly every time. This function (initialize) therefore stands for initialization/re-initialization. I don't know, I feel pretty good about this, could you specify what exactly is unsafe here? Or any "real" arguments against the current solution? | |
| 86–88 | yes, right | |
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 85–102 ↗ | (On Diff #16352) | That is ok but we'd not have error message available when using while let |