Page MenuHomePhabricator
Differential D5029

[services] Rust Integration - Backup - Stop rethrowing in create new backup reactor
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:57 AM
Unknown Object (File)
Tue, Oct 29, 4:22 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:09 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
Commits
rCOMM30ddf06329be: [services] Rust Integration - Backup - Stop rethrowing in create new backup…
Summary

Depends on D5027

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Here, I removed rethrowing in create new backup reactor as it is caught in the base reactors (earlier in this stack).

Test Plan
cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:54 PM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:54 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 2 2022, 12:01 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5028: [services] Rust Integration - Backup - Stop rethrowing in add attachments utility.
Harbormaster completed remote builds in B11817: Diff 16222.Sep 2 2022, 12:05 AM
• karol requested review of this revision.Sep 2 2022, 12:05 AM
• karol added a child revision: D5030: [services] Rust Integration - Backup - Make report_error shared.Sep 2 2022, 12:05 AM
• karol updated this revision to Diff 16229.Sep 2 2022, 12:36 AM

update

Harbormaster failed remote builds in B11824: Diff 16229!Sep 2 2022, 12:40 AM
• karol planned changes to this revision.Sep 2 2022, 12:54 AM

CI

• karol added a comment.Sep 2 2022, 4:07 AM

It builds on my mac, also cargo check works (and the CI error is from rust). Not sure what's going on, I'm going to restart the CI.

• karol updated this revision to Diff 16238.Sep 2 2022, 4:08 AM

retrigger CI

Harbormaster completed remote builds in B11833: Diff 16238.Sep 2 2022, 4:15 AM
tomek accepted this revision.Sep 5 2022, 7:32 AM
This revision is now accepted and ready to land.Sep 5 2022, 7:32 AM
• karol edited the summary of this revision. (Show Details)Sep 6 2022, 3:49 AM
• karol added a parent revision: D5027: [services] Rust Integration - Backup - Stop rethrowing in send log reactor.
• karol removed a parent revision: D5028: [services] Rust Integration - Backup - Stop rethrowing in add attachments utility.
• karol updated this revision to Diff 16457.Sep 8 2022, 4:03 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMM30ddf06329be: [services] Rust Integration - Backup - Stop rethrowing in create new backup… (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM30ddf06329be: [services] Rust Integration - Backup - Stop rethrowing in create new backup….
Harbormaster completed remote builds in B12002: Diff 16457.Sep 8 2022, 4:29 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
60 lines

Diff 16457

View Options

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...