Paths

Table of Contentst

Differential D5034

[services] Rust Integration - Backup - Rust - Add converting functions
ClosedPublic
Actions

Authored by • karol on Sep 2 2022, 10:51 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

• jon
tomek
varun
• max

Commits

rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions

Summary

Depends on D5031

Adding helper functions to convert between rust's String and c++'s char* both ways.

Test Plan

backup builds successfully

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 2 2022, 10:51 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 2 2022, 10:51 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 2 2022, 10:55 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • max.

• karol added a parent revision: D5031: [services] Rust Integration - Backup - Make check_error shared.

• karol added a child revision: D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.Sep 2 2022, 10:59 AM

Harbormaster completed remote builds in B11828: Diff 16233.Sep 2 2022, 11:01 AM

• karol requested review of this revision.Sep 2 2022, 11:01 AM

tomek requested changes to this revision.Sep 5 2022, 2:49 PM

tomek added inline comments.

services/backup/blob_client/src/tools.rs
37 ↗	(On Diff #16233)	We should avoid using `unwrap`

This revision now requires changes to proceed.Sep 5 2022, 2:49 PM

• karol added inline comments.Sep 6 2022, 11:22 AM

services/backup/blob_client/src/tools.rs
37 ↗	(On Diff #16233)	Right, I will fix this.

avoid unwrap

Harbormaster completed remote builds in B11913: Diff 16356.Sep 6 2022, 11:31 AM

tomek accepted this revision.Sep 7 2022, 1:02 PM

tomek added inline comments.

services/backup/blob_client/src/tools.rs
1 ↗	(On Diff #16356)	Do we need this line?
23–25 ↗	(On Diff #16356)	This should be formatted in the diff that introduced this code.
35 ↗	(On Diff #16356)	This line seems to be too long - is it formatted?

This revision is now accepted and ready to land.Sep 7 2022, 1:02 PM

• karol added inline comments.Sep 8 2022, 10:37 AM

services/backup/blob_client/src/tools.rs
1 ↗	(On Diff #16356)	Apparently, no. Weird that `cargo check` didn't catch this.
35 ↗	(On Diff #16356)	will do

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 11:10 AM

Closed by commit rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions.

Harbormaster completed remote builds in B12005: Diff 16460.Sep 8 2022, 11:35 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

26 lines

Diff 16460

services/backup/blob_client/src/tools.rs

Loading...