Paths

Table of Contentst

-
services/backup/blob_client/src/
-
backup/
-
blob_client/
-
src/
-
put_client.rs

[services] Backup - Blob Get Client - Refactor put write
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:44 AM.

Details

Reviewers

• jon
• max
tomek
varun

Commits

rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write

Summary

Depends on D5093

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Using a new way of error handling in the write method of the put client.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob and backup (in this particular order), this still works:

yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Sep 9 2022, 4:44 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:44 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B12047: Diff 16546.Sep 9 2022, 4:54 AM

• karol requested review of this revision.Sep 9 2022, 4:54 AM

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:54 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek, varun.

• karol added a parent revision: D5093: [services] Backup - Blob Get Client - Refactor put terminate.

• karol added a child revision: D5095: [services] Backup - Blob Get Client - Refactor put read.

• jon accepted this revision.Sep 9 2022, 10:49 AM

This revision is now accepted and ready to land.Sep 9 2022, 10:49 AM

It's great to see the function simplified by a lot!

services/backup/blob_client/src/put_client.rs
244 ↗	(On Diff #16546)

• karol added inline comments.Sep 19 2022, 7:14 AM

services/backup/blob_client/src/put_client.rs
244 ↗	(On Diff #16546)	https://linear.app/comm/issue/ENG-1841/use-short-version-of-anyhow-result

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:28 AM

Closed by commit rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write.

Harbormaster completed remote builds in B12281: Diff 16843.Sep 19 2022, 7:39 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

30 lines

Diff 16852

View Options

services/backup/blob_client/src/put_client.rs

	Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines

	### Workflow specific prerequisites			### Workflow specific prerequisites

	On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.			On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.

	- [Web prerequisites](./nix_web_setup.md#nix-web-requisities)			- [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
	- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)			- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
	- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)			- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
	- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
	- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)			- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
	- [iOS development](./nix_mobile_setup.md#ios-development)			- [iOS development](./nix_mobile_setup.md#ios-development)
	- [Xcode](./nix_mobile_setup.md#xcode)			- [Xcode](./nix_mobile_setup.md#xcode)
	- [Xcode settings](./nix_mobile_setup.md#xcode-settings)			- [Xcode settings](./nix_mobile_setup.md#xcode-settings)
	- [Android development](./nix_mobile_setup.md#android-development)			- [Android development](./nix_mobile_setup.md#android-development)
	- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)			- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
	- [Android Studio](./nix_mobile_setup.md#android-studio)			- [Android Studio](./nix_mobile_setup.md#android-studio)
	- [Android SDK](./nix_mobile_setup.md#android-sdk)			- [Android SDK](./nix_mobile_setup.md#android-sdk)
	- [Android emulator](./nix_mobile_setup.md#android-emulator)			- [Android emulator](./nix_mobile_setup.md#android-emulator)
	- [Debugging tools](./nix_mobile_setup.md#debugging-tools)			- [Debugging tools](./nix_mobile_setup.md#debugging-tools)
	- [Homebrew](./nix_mobile_setup.md#homebrew)			- [Homebrew](./nix_mobile_setup.md#homebrew)
	- [Reactotron](./nix_mobile_setup.md#reactotron)			- [Reactotron](./nix_mobile_setup.md#reactotron)
	- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
	- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)

	# Development environment			# Development environment

	Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).			Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).

	## Development workflows			## Development workflows

	- [Web workflows](./nix_web_workflows.md#development)			- [Web workflows](./nix_web_workflows.md#development)
	Show All 27 Lines

[services] Backup - Blob Get Client - Refactor put writeClosedPublicActions