Page MenuHomePhabricator
Differential D8708

[web] seperate out each reaction into their own pill
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 11:57 AM.
Tags
None
Referenced Files
F4949096: D8708.id30375.diff
Thu, Mar 20, 3:15 AM
F4949095: D8708.id30363.diff
Thu, Mar 20, 3:15 AM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:15 PM
Unknown Object (File)
Mon, Mar 17, 6:07 PM
Unknown Object (File)
Wed, Mar 12, 5:15 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill
Summary

The next step to redesigning the InlineEngagement component is to split out each reaction into its own pill.

Depends on D8707

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 2 2023, 11:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 11:57 AM
ginsu edited the summary of this revision. (Show Details)Aug 2 2023, 12:03 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8707: [web] add space between inline engagement container and edges of chat window.
ginsu attached a referenced file: F672387: Screen Recording 2023-08-02 at 3.01.58 PM.mov. (Show Details)
ginsu added inline comments.Aug 2 2023, 12:06 PM
web/chat/inline-engagement.css
67–68

We can get rid of this because of the gap property we added above

web/chat/inline-engagement.react.js
9

The next diff will handle cleaning up this now unused function

26

This got moved to line 54

ginsu mentioned this in D8709: [web] deprecate stringForReactionList.Aug 2 2023, 12:09 PM
ginsu added a child revision: D8709: [web] deprecate stringForReactionList.Aug 2 2023, 12:13 PM
ginsu published this revision for review.Aug 2 2023, 12:25 PM
Harbormaster failed remote builds in B21495: Diff 29488!Aug 2 2023, 12:44 PM
atul accepted this revision.Aug 3 2023, 9:29 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:29 PM
Harbormaster completed remote builds in B21495: Diff 29488.Aug 3 2023, 9:36 PM
ginsu updated this revision to Diff 30363.Aug 27 2023, 7:49 PM

rebase before landing

Harbormaster completed remote builds in B22129: Diff 30363.Aug 27 2023, 8:06 PM
Closed by commit rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill.

Revision Contents
Changeset List

PathSize
web/
chat/
10 lines
54 lines

Diff 29488

View Options

web/chat/inline-engagement.css

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

web/chat/inline-engagement.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines