Page MenuHomePhabricator
Differential D8710

[web] make reactions prop for InlineEngagement requried
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 12:19 PM.
Tags
None
Referenced Files
F2062991: D8710.id.diff
Fri, Jun 21, 3:38 AM
F2061643: D8710.id29492.diff
Fri, Jun 21, 12:10 AM
Unknown Object (File)
Wed, Jun 19, 9:38 PM
Unknown Object (File)
Sun, Jun 16, 3:35 AM
Unknown Object (File)
Sat, Jun 15, 4:59 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried
Summary

In the next few diffs we will introduce the functionality to send a reaction by clicking on a pill. To prepare for this we need to make reactions prop required so we can use the sendReaction hook

Depends on D8709

Test Plan

flow and confirmed that InlineEngagement still looks and works as expected for comopsed message and robotext messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 2 2023, 12:19 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 12:19 PM
ginsu edited the summary of this revision. (Show Details)Aug 2 2023, 12:20 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8709: [web] deprecate stringForReactionList.
ginsu published this revision for review.Aug 2 2023, 12:25 PM
ginsu added a child revision: D8711: [web] move reaction message action type logic into useSendReaction.Aug 2 2023, 12:31 PM
Harbormaster completed remote builds in B21498: Diff 29492.Aug 2 2023, 2:13 PM
atul accepted this revision.Aug 3 2023, 9:30 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:30 PM
ginsu updated this revision to Diff 30365.Aug 27 2023, 7:50 PM

rebase before landing

Harbormaster completed remote builds in B22131: Diff 30365.Aug 27 2023, 8:07 PM
Closed by commit rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried.

Revision Contents
Changeset List

PathSize
web/
chat/
7 lines

Diff 29492

View Options

web/chat/inline-engagement.react.js

Loading...