Page MenuHomePhabricator

[web] make reactions prop for InlineEngagement requried
ClosedPublic

Authored by ginsu on Aug 2 2023, 12:19 PM.
Tags
None
Referenced Files
F2067025: D8710.id30377.diff
Fri, Jun 21, 1:31 PM
F2062991: D8710.id.diff
Fri, Jun 21, 3:38 AM
F2061643: D8710.id29492.diff
Fri, Jun 21, 12:10 AM
Unknown Object (File)
Wed, Jun 19, 9:38 PM
Unknown Object (File)
Sun, Jun 16, 3:35 AM
Unknown Object (File)
Sat, Jun 15, 4:59 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
Subscribers

Details

Summary

In the next few diffs we will introduce the functionality to send a reaction by clicking on a pill. To prepare for this we need to make reactions prop required so we can use the sendReaction hook

Depends on D8709

Test Plan

flow and confirmed that InlineEngagement still looks and works as expected for comopsed message and robotext messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added reviewers: atul, kamil.
ginsu published this revision for review.Aug 2 2023, 12:25 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:30 PM