[web] make reactions prop for InlineEngagement requried
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 12:19 PM.

Details

Reviewers

atul
kamil

Commits

rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried

Summary

In the next few diffs we will introduce the functionality to send a reaction by clicking on a pill. To prepare for this we need to make reactions prop required so we can use the sendReaction hook

Depends on D8709

Test Plan

flow and confirmed that InlineEngagement still looks and works as expected for comopsed message and robotext messages

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Aug 2 2023, 12:19 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 12:19 PM

ginsu edited the summary of this revision. (Show Details)Aug 2 2023, 12:20 PM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8709: [web] deprecate stringForReactionList.

ginsu published this revision for review.Aug 2 2023, 12:25 PM

ginsu added a child revision: D8711: [web] move reaction message action type logic into useSendReaction.Aug 2 2023, 12:31 PM

Harbormaster completed remote builds in B21498: Diff 29492.Aug 2 2023, 2:13 PM

atul accepted this revision.Aug 3 2023, 9:30 PM

This revision is now accepted and ready to land.Aug 3 2023, 9:30 PM

rebase before landing

Harbormaster completed remote builds in B22131: Diff 30365.Aug 27 2023, 8:07 PM

Closed by commit rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM5a07a952fc9d: [web] make reactions prop for InlineEngagement requried.

Revision Contents
Changeset List

Path

Size

web/

chat/

inline-engagement.react.js

7 lines

Diff 30365

View Options

web/chat/inline-engagement.react.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	if (sessionItem == nullptr) {
LOG(INFO) << "gRPC: "		LOG(INFO) << "gRPC: "
<< "Session " << sessionID << " not found";		<< "Session " << sessionID << " not found";
return grpc::Status(		return grpc::Status(
grpc::StatusCode::PERMISSION_DENIED,		grpc::StatusCode::PERMISSION_DENIED,
"No such session found. SessionID: " + sessionID);		"No such session found. SessionID: " + sessionID);
}		}
const std::string clientDeviceID = sessionItem->getDeviceID();		const std::string clientDeviceID = sessionItem->getDeviceID();
const std::string messageID = tools::generateUUID();		const std::string messageID = tools::generateUUID();

		const database::MessageItem message(
		messageID,
		clientDeviceID,
		request->todeviceid(),
		request->payload(),
		"");
		database::DatabaseManager::getInstance().putMessageItem(message);
if (!AmqpManager::getInstance().send(		if (!AmqpManager::getInstance().send(
messageID,		messageID,
clientDeviceID,		clientDeviceID,
request->todeviceid(),		request->todeviceid(),
std::string(request->payload()))) {		std::string(request->payload()))) {
LOG(ERROR) << "gRPC: "		LOG(ERROR) << "gRPC: "
<< "Error while publish the message to AMQP";		<< "Error while publish the message to AMQP";
return grpc::Status(		return grpc::Status(
Show All 27 Lines	if (sessionItem == nullptr) {
LOG(INFO) << "gRPC: "		LOG(INFO) << "gRPC: "
<< "Session " << sessionID << " not found";		<< "Session " << sessionID << " not found";
return grpc::Status(		return grpc::Status(
grpc::StatusCode::PERMISSION_DENIED,		grpc::StatusCode::PERMISSION_DENIED,
"No such session found. SessionID: " + sessionID);		"No such session found. SessionID: " + sessionID);
}		}
const std::string clientDeviceID = sessionItem->getDeviceID();		const std::string clientDeviceID = sessionItem->getDeviceID();
DeliveryBrokerMessage messageToDeliver;		DeliveryBrokerMessage messageToDeliver;

		std::vector<std::shared_ptr<database::MessageItem>> messagesFromDatabase =
		database::DatabaseManager::getInstance().findMessageItemsByReceiver(
		clientDeviceID);
		if (messagesFromDatabase.size() > 0) {
		// When a client connects and requests GET for the messages first we check
		// if there are undelivered messages in the database. If so, we are
		// erasing the messages to deliver from rabbitMQ which are handled by
		// DeliveryBroker.
		DeliveryBroker::getInstance().erase(clientDeviceID);
		}
		for (auto &messageFromDatabase : messagesFromDatabase) {
		tunnelbroker::GetResponse response;
		karolUnsubmitted Done Inline Actions Nit: we could define this outside of the loop. karol: Nit: we could define this outside of the loop.
		maxAuthorUnsubmitted Done Inline Actions Nit: we could define this outside of the loop. Nice optimization catch! We can use a single instance and use grpc generated `Clear()` method on it. max: > Nit: we could define this outside of the loop. Nice optimization catch! We can use a single…
		response.set_fromdeviceid(messageFromDatabase->getFromDeviceID());
		response.set_payload(messageFromDatabase->getPayload());
		if (!writer->Write(response)) {
		throw std::runtime_error(
		"gRPC: 'Get' writer error on sending data to the client");
		}
		database::DatabaseManager::getInstance().removeMessageItem(
		messageFromDatabase->getMessageID());
		}
while (1) {		while (1) {
messageToDeliver = DeliveryBroker::getInstance().pop(clientDeviceID);		messageToDeliver = DeliveryBroker::getInstance().pop(clientDeviceID);
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
response.set_fromdeviceid(messageToDeliver.fromDeviceID);		response.set_fromdeviceid(messageToDeliver.fromDeviceID);
response.set_payload(messageToDeliver.payload);		response.set_payload(messageToDeliver.payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
comm::network::AmqpManager::getInstance().ack(		comm::network::AmqpManager::getInstance().ack(
messageToDeliver.deliveryTag);		messageToDeliver.deliveryTag);
if (DeliveryBroker::getInstance().isEmpty(clientDeviceID)) {		database::DatabaseManager::getInstance().removeMessageItem(
DeliveryBroker::getInstance().erase(clientDeviceID);		messageToDeliver.messageID);
}		DeliveryBroker::getInstance().deleteQueueIfEmpty(clientDeviceID);
}		}
} catch (std::runtime_error &e) {		} catch (std::runtime_error &e) {
LOG(ERROR) << "gRPC: "		LOG(ERROR) << "gRPC: "
<< "Error while processing 'Get' request: " << e.what();		<< "Error while processing 'Get' request: " << e.what();
return grpc::Status(grpc::StatusCode::INTERNAL, e.what());		return grpc::Status(grpc::StatusCode::INTERNAL, e.what());
}		}
return grpc::Status::OK;		return grpc::Status::OK;
};		};

} // namespace network		} // namespace network
} // namespace comm		} // namespace comm

[web] make reactions prop for InlineEngagement requriedClosedPublicActions