Page MenuHomePhabricator

[services] Rust Integration - Backup - Stop rethrowing in create new backup reactor
ClosedPublic

Authored by karol on Sep 1 2022, 11:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:52 AM
Unknown Object (File)
Sun, Nov 10, 6:57 AM
Unknown Object (File)
Tue, Oct 29, 4:22 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM
Unknown Object (File)
Sun, Oct 27, 8:12 PM

Details

Summary

Depends on D5027

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Here, I removed rethrowing in create new backup reactor as it is caught in the base reactors (earlier in this stack).

Test Plan
cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

It builds on my mac, also cargo check works (and the CI error is from rust). Not sure what's going on, I'm going to restart the CI.

This revision is now accepted and ready to land.Sep 5 2022, 7:32 AM
This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
This revision was automatically updated to reflect the committed changes.