Page MenuHomePhabricator
Differential D5034

[services] Rust Integration - Backup - Rust - Add converting functions
ClosedPublic
Actions

Authored by • karol on Sep 2 2022, 3:51 AM.
Tags
None
Referenced Files
F5102375: D5034.diff
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Wed, Mar 26, 8:22 AM
Unknown Object (File)
Thu, Mar 13, 1:34 PM
Unknown Object (File)
Wed, Mar 12, 6:54 AM
Unknown Object (File)
Sun, Mar 9, 5:15 AM
Unknown Object (File)
Sat, Mar 8, 4:27 AM
Unknown Object (File)
Mon, Mar 3, 6:17 PM
Unknown Object (File)
Mon, Mar 3, 6:17 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
varun
• max
Commits
rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions
Summary

Depends on D5031

Adding helper functions to convert between rust's String and c++'s char* both ways.

Test Plan

backup builds successfully

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 2 2022, 3:51 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 2 2022, 3:51 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 2 2022, 3:55 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun, • max.
• karol added a parent revision: D5031: [services] Rust Integration - Backup - Make check_error shared.
• karol added a child revision: D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.Sep 2 2022, 3:59 AM
Harbormaster completed remote builds in B11828: Diff 16233.Sep 2 2022, 4:01 AM
• karol requested review of this revision.Sep 2 2022, 4:01 AM
tomek requested changes to this revision.Sep 5 2022, 7:49 AM
tomek added inline comments.
services/backup/blob_client/src/tools.rs
37 ↗(On Diff #16233)

We should avoid using unwrap

This revision now requires changes to proceed.Sep 5 2022, 7:49 AM
• karol added inline comments.Sep 6 2022, 4:22 AM
services/backup/blob_client/src/tools.rs
37 ↗(On Diff #16233)

Right, I will fix this.

• karol updated this revision to Diff 16356.Sep 6 2022, 4:22 AM

avoid unwrap

Harbormaster completed remote builds in B11913: Diff 16356.Sep 6 2022, 4:31 AM
tomek accepted this revision.Sep 7 2022, 6:02 AM
tomek added inline comments.
services/backup/blob_client/src/tools.rs
1 ↗(On Diff #16356)

Do we need this line?

23–25 ↗(On Diff #16356)

This should be formatted in the diff that introduced this code.

35 ↗(On Diff #16356)

This line seems to be too long - is it formatted?

This revision is now accepted and ready to land.Sep 7 2022, 6:02 AM
• karol added inline comments.Sep 8 2022, 3:37 AM
services/backup/blob_client/src/tools.rs
1 ↗(On Diff #16356)

Apparently, no. Weird that cargo check didn't catch this.

35 ↗(On Diff #16356)

will do

• karol updated this revision to Diff 16460.Sep 8 2022, 4:04 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM396b990da3e4: [services] Rust Integration - Backup - Rust - Add converting functions.
Harbormaster completed remote builds in B12005: Diff 16460.Sep 8 2022, 4:35 AM

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
src/
26 lines

Diff 16460

View Options

services/backup/blob_client/src/tools.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { import type {
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
UpdateThreadRequest, UpdateThreadRequest,
ClientNewThreadRequest, ClientNewThreadRequest,
NewThreadResult, NewThreadResult,
ClientThreadJoinRequest, ClientThreadJoinRequest,
ThreadJoinPayload, ThreadJoinPayload,
ThreadFetchMediaRequest, ThreadFetchMediaRequest,
ThreadFetchMediaResult, ThreadFetchMediaResult,
ToggleMessagePinRequest,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const deleteThreadActionTypes = Object.freeze({ const deleteThreadActionTypes = Object.freeze({
started: 'DELETE_THREAD_STARTED', started: 'DELETE_THREAD_STARTED',
success: 'DELETE_THREAD_SUCCESS', success: 'DELETE_THREAD_SUCCESS',
failed: 'DELETE_THREAD_FAILED', failed: 'DELETE_THREAD_FAILED',
▲ Show 20 Lines • Show All 146 Lines • ▼ Show 20 Linesconst fetchThreadMedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) => ): ((request: ThreadFetchMediaRequest) => Promise<ThreadFetchMediaResult>) =>
async request => { async request => {
const response = await callServerEndpoint('fetch_thread_media', request); const response = await callServerEndpoint('fetch_thread_media', request);
return response; return response;
}; };
const toggleMessagePin =
(
callServerEndpoint: CallServerEndpoint,
): ((request: ToggleMessagePinRequest) => Promise<void>) =>
async request => {
await callServerEndpoint('toggle_message_pin', request);
};
export { export {
deleteThreadActionTypes, deleteThreadActionTypes,
deleteThread, deleteThread,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
changeThreadSettings, changeThreadSettings,
removeUsersFromThreadActionTypes, removeUsersFromThreadActionTypes,
removeUsersFromThread, removeUsersFromThread,
changeThreadMemberRolesActionTypes, changeThreadMemberRolesActionTypes,
changeThreadMemberRoles, changeThreadMemberRoles,
newThreadActionTypes, newThreadActionTypes,
newThread, newThread,
joinThreadActionTypes, joinThreadActionTypes,
joinThread, joinThread,
leaveThreadActionTypes, leaveThreadActionTypes,
leaveThread, leaveThread,
fetchThreadMedia, fetchThreadMedia,
toggleMessagePin,
}; };