Paths

Table of Contentst

[services] Backup - Blob Get Client - Refactor put write
ClosedPublic
Actions

Authored by • karol on Sep 9 2022, 4:44 AM.

Details

Reviewers

• jon
• max
tomek
varun

Commits

rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write

Summary

Depends on D5093

Linear task: https://linear.app/comm/issue/ENG-1734/improve-error-handling-system-in-the-blob-client

Using a new way of error handling in the write method of the put client.

Test Plan

cd services/backup/blob_client
cargo check

after running localstack, blob and backup (in this particular order), this still works:

yarn run-performance-tests backup

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 9 2022, 4:44 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 9 2022, 4:44 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B12047: Diff 16546.Sep 9 2022, 4:54 AM

• karol requested review of this revision.Sep 9 2022, 4:54 AM

• karol edited the summary of this revision. (Show Details)Sep 9 2022, 4:54 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek, varun.

• karol added a parent revision: D5093: [services] Backup - Blob Get Client - Refactor put terminate.

• karol added a child revision: D5095: [services] Backup - Blob Get Client - Refactor put read.

• jon accepted this revision.Sep 9 2022, 10:49 AM

This revision is now accepted and ready to land.Sep 9 2022, 10:49 AM

It's great to see the function simplified by a lot!

services/backup/blob_client/src/put_client.rs
244 ↗	(On Diff #16546)

• karol added inline comments.Sep 19 2022, 7:14 AM

services/backup/blob_client/src/put_client.rs
244 ↗	(On Diff #16546)	https://linear.app/comm/issue/ENG-1841/use-short-version-of-anyhow-result

rebase

This revision was landed with ongoing or failed builds.Sep 19 2022, 7:28 AM

Closed by commit rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write.

Harbormaster completed remote builds in B12281: Diff 16843.Sep 19 2022, 7:39 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

30 lines

Diff 16843

View Options

services/backup/blob_client/src/put_client.rs

[services] Backup - Blob Get Client - Refactor put writeClosedPublicActions