Page MenuHomePhabricator

[web] Use chat mention candidates in markdown rules
ClosedPublic

Authored by patryk on Aug 17 2023, 10:03 AM.
Tags
None
Referenced Files
F3181278: D8851.id30692.diff
Fri, Nov 8, 6:02 AM
F3180662: D8851.id30022.diff
Fri, Nov 8, 5:08 AM
Unknown Object (File)
Sun, Oct 27, 2:49 PM
Unknown Object (File)
Mon, Oct 14, 3:37 PM
Unknown Object (File)
Mon, Oct 14, 12:27 PM
Unknown Object (File)
Oct 4 2024, 7:39 AM
Unknown Object (File)
Sep 30 2024, 9:22 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Subscribers

Details

Summary

This diff adds the chatMentionCandidates object to all functions that return textMessageRules in rules.react.js, and includes this object as a parameter in all occurrences of these functions.

Depends on D8871, D8834.

Test Plan

Before testing, please apply the entire web stack.

  1. Check if mentions are rendered correctly (see D8852).
  2. Check if mention content is not replaced to default text (@[[id:default text]]) when pending sidebar is created.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mention-web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka, rohan.
patryk edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 28 2023, 4:01 AM

Change getDefaultTextMessageRules

We probably should memoize the rules

Rebase and early return textMessageRules