Add new one-time-keys table for both content and notif keys.
https://linear.app/comm/issue/ENG-4535
Depends on D8642
Paths
| Differential D8675 Authored by • jon on Jul 31 2023, 7:02 AM.
Details
Summary Add new one-time-keys table for both content and notif keys. https://linear.app/comm/issue/ENG-4535 Depends on D8642 Test Plan cd services/terraform/dev ./run.sh The two identity-*-onetime-keys should be created. The constants in service/identity/ are tested later
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Harbormaster completed remote builds in B21471: Diff 29449.Aug 1 2023, 10:52 AM2023-08-01 10:52:44 (UTC-7) Harbormaster completed remote builds in B21473: Diff 29452.Aug 1 2023, 11:20 AM2023-08-01 11:20:46 (UTC-7) Harbormaster completed remote builds in B21478: Diff 29457.Aug 1 2023, 12:28 PM2023-08-01 12:28:55 (UTC-7) Harbormaster completed remote builds in B21513: Diff 29510.Aug 3 2023, 11:56 AM2023-08-03 11:56:02 (UTC-7) Comment Actions Not [yet] an expert when it comes to DDB batch writes so leaving this part to @varun Besides that, LGTM
This revision now requires changes to proceed.Aug 4 2023, 12:06 PM2023-08-04 12:06:08 (UTC-7) • jon marked 4 inline comments as done. Comment ActionsAddress feedback
Harbormaster completed remote builds in B21592: Diff 29631.Aug 8 2023, 10:10 AM2023-08-08 10:10:48 (UTC-7) This revision now requires changes to proceed.Aug 8 2023, 10:19 AM2023-08-08 10:19:38 (UTC-7) • jon marked an inline comment as done. Comment ActionsChunkify other BatchWriteItem
Harbormaster completed remote builds in B21593: Diff 29632.Aug 8 2023, 10:50 AM2023-08-08 10:50:51 (UTC-7) Comment Actions sorry I didn't catch this earlier but we should be consistent about onetime vs one-time/oneTime/OneTime/one_time. the latter matches the white paper, so we should remove all uses of the former. i noted a couple instances where we're using the wrong format inline, but it's not an exhaustive list. some other comments inline too. also, we have to update the add_user_to_users_table function, right?
This revision now requires changes to proceed.Aug 9 2023, 3:14 PM2023-08-09 15:14:46 (UTC-7) Comment Actions
Sigh, I was going off the naming you had in constants.rs. Do you mind if I just create a follow up task to rename all instances of onetime/ONETIME to one-time/ONE_TIME. I really don't want to deal with those kinds of rebase conflicts in the current stack.... • jon marked an inline comment as done. • jon added inline comments.
Harbormaster completed remote builds in B21743: Diff 29881.Aug 15 2023, 7:17 AM2023-08-15 07:17:18 (UTC-7) • jon marked 3 inline comments as done. Comment Actionsuggh, not sure why, but I got a stale patch when doing the one-time refactor • jon marked an inline comment as done. Comment ActionsRe-apply feedback which was lost during bad arc patch Harbormaster completed remote builds in B21766: Diff 29919.Aug 15 2023, 10:56 AM2023-08-15 10:56:42 (UTC-7) Harbormaster completed remote builds in B21767: Diff 29920.Aug 15 2023, 11:01 AM2023-08-15 11:01:16 (UTC-7) Comment Actions
sorry to keep requesting changes but i'm still not seeing this change in the diff
This revision now requires changes to proceed.Aug 16 2023, 6:59 AM2023-08-16 06:59:47 (UTC-7) • jon marked an inline comment as done. Comment ActionsAddress comments, refactor one time key addtions to single method Harbormaster completed remote builds in B21819: Diff 29991.Aug 17 2023, 12:43 AM2023-08-17 00:43:51 (UTC-7) Harbormaster completed remote builds in B21820: Diff 29992.Aug 17 2023, 12:46 AM2023-08-17 00:46:10 (UTC-7)
Harbormaster completed remote builds in B21854: Diff 30028.Aug 17 2023, 10:42 AM2023-08-17 10:42:58 (UTC-7) Comment Actions can you please create a follow up task for renaming affected db methods? e.g. add_user_to_users_table -> add_user_to_ddb, add_password_user_to_users_table -> add_password_user_to_ddb, add_device_to_users_table -> add_device_to_ddb (these are just suggestions, i'm open to other names)
This revision is now accepted and ready to land.Aug 17 2023, 11:50 AM2023-08-17 11:50:47 (UTC-7) Harbormaster completed remote builds in B21928: Diff 30115.Aug 20 2023, 10:13 PM2023-08-20 22:13:23 (UTC-7) Closed by commit rCOMMbdabed9dccb1: [Identity] Add DDB table for one-time-keys (authored by • jon). · Explain WhyAug 20 2023, 10:24 PM2023-08-20 22:24:16 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 30027 services/commtest/tests/identity_one_time_key_tests.rs
services/identity/src/client_service.rs
services/identity/src/constants.rs
services/identity/src/database.rs
|