This diff adds the chatMentionCandidates object to all functions that return textMessageRules in rules.react.js, and includes this object as a parameter in all occurrences of these functions.
Depends on D8871.
Differential D8846
[native] Use chat mention candidates in markdown rules • patryk on Aug 17 2023, 6:22 AM. Authored by Tags None Referenced Files
Details This diff adds the chatMentionCandidates object to all functions that return textMessageRules in rules.react.js, and includes this object as a parameter in all occurrences of these functions. Depends on D8871. Before testing, please apply the entire native stack.
Diff Detail
Event Timeline
Comment Actions It might make sense to introduce a new hook that:
Comment Actions @tomek's improvement makes sense, but I'm not applying them right now because I don't believe it will bring significant improvements. If there will be any performance issues during testing, it might be worth wrapping default rules with memo. |