Page MenuHomePhabricator
Differential D8876

[web] Inherit colors on spoiler reveal animation
ClosedPublic
Actions

Authored by • patryk on Aug 19 2023, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:16 PM
Unknown Object (File)
Fri, Nov 8, 4:16 PM
Unknown Object (File)
Fri, Nov 8, 4:16 PM
Unknown Object (File)
Fri, Nov 8, 4:08 PM
Unknown Object (File)
Fri, Nov 8, 3:59 PM
Unknown Object (File)
Oct 29 2024, 8:55 AM
Unknown Object (File)
Oct 25 2024, 5:54 PM
Unknown Object (File)
Oct 14 2024, 10:45 PM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMMac52e9f1e69a: [web] Inherit colors on spoiler reveal animation
Summary

Solution for ENG-4675.

This diff fixes the issue where, after the spoiler reveal animation, the content color was being changed.

Depends on D8877.

Test Plan
  1. Before applying this patch, check if current spoiler reveal animation does change the content color:

  1. Apply this patch and see if colors are not changed:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 19 2023, 2:31 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 19 2023, 2:31 PM
Harbormaster completed remote builds in B21922: Diff 30109.Aug 19 2023, 2:49 PM
• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 3:37 PM
• patryk added a parent revision: D8875: [web] Make chat mentions clickable.
• patryk added a child revision: D8853: [web] Add chat mention rule to text message rules.
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 6:51 AM
• patryk added a parent revision: D8877: [web] Fix spoiler animation for links.
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 9:01 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk edited the test plan for this revision. (Show Details)Aug 20 2023, 9:23 AM
• patryk updated this revision to Diff 30113.Aug 20 2023, 9:25 AM
• patryk edited the test plan for this revision. (Show Details)

Fix diff

Harbormaster completed remote builds in B21926: Diff 30113.Aug 20 2023, 9:44 AM
• patryk added inline comments.Aug 20 2023, 2:34 PM
web/markdown/markdown.css
96–97 ↗(On Diff #30113)

Color should be overriden only when spoiler is closed.

• patryk attached a referenced file: F698092: before-link-color-change-web.mp4. (Show Details)Aug 20 2023, 11:10 PM
• patryk attached a referenced file: F698106: after-link-color-change-web.mp4. (Show Details)
• patryk published this revision for review.Aug 20 2023, 11:15 PM
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 11:25 PM
inka accepted this revision.Aug 21 2023, 4:19 AM
This revision is now accepted and ready to land.Aug 21 2023, 4:19 AM
• patryk removed a parent revision: D8875: [web] Make chat mentions clickable.Aug 21 2023, 6:11 AM
ashoat added a comment.Aug 21 2023, 9:20 AM

Great find! Thanks for fixing this.

rohan accepted this revision.Aug 21 2023, 5:09 PM

Thanks for fixing this!

Closed by commit rCOMMac52e9f1e69a: [web] Inherit colors on spoiler reveal animation (authored by • patryk). · Explain WhySep 28 2023, 2:10 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMac52e9f1e69a: [web] Inherit colors on spoiler reveal animation.

Revision Contents
Changeset List

PathSize
web/
markdown/
2 lines

Diff 30109

View Options

web/markdown/markdown.css

Loading...