Details
Details
- Reviewers
tomek inka rohan - Commits
- rCOMM2e9c0b06d51f: [web] Fix spoiler animation for links
- Before applying this patch, check if current spoiler reveal animation doesn't work for links:
- Apply this patch and see if animation works for links too:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Thanks for taking the time to improve the codebase, even though it doesn't pertain to your work exactly :)
We definitely should return something from this lambda since otherwise it is useless to assign it to variable.
If we find that we don't have permissions then just calling await this.requestAndroidNotificationsPermission(); would result in a prompt asking for notifications permissions. However if the user grants those permissions then hasPermissions is still falsy (since promise returned nothing), so deviceToken will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render.
This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state.