Paths

Table of Contentst

-
native/chat/
-
chat/
-
chat-input-bar.react.js

Differential D8909

[native] Replace chat name with raw chat mention
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 5:26 AM.

Tags

None

Referenced Files

	F5107439: D8909.diff
	Tue, Apr 1, 11:04 AM

	Unknown Object (File)
	Wed, Mar 26, 6:36 AM

	Unknown Object (File)
	Thu, Mar 20, 1:07 AM

	Unknown Object (File)
	Mon, Mar 17, 3:21 AM

	Unknown Object (File)
	Mon, Mar 17, 3:21 AM

	Unknown Object (File)
	Tue, Mar 11, 11:33 PM

	Unknown Object (File)
	Thu, Mar 6, 5:29 PM

	Unknown Object (File)
	Wed, Mar 5, 3:01 PM

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM569949568558: [native] Replace chat name with raw chat mention

Summary

Solution for ENG-4553 and ENG-4555.

This diff adds support for chats in mentionTypeaheadTooltipActions . Chat entry is encoded in the following convention:

@[[chat_id:default_text]]

Depends on D8908.

Test Plan

Tested later in the stack.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• patryk created this revision.Aug 22 2023, 5:26 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 5:26 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:32 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka, rohan.

• patryk edited the summary of this revision. (Show Details)

• patryk added a parent revision: D8908: [lib] Encode chat name in raw chat mention.

• patryk added a child revision: D8910: [native] Show chats in mention typeahead tooltip.Aug 22 2023, 5:34 AM

Harbormaster completed remote builds in B22006: Diff 30215.Aug 22 2023, 5:43 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:51 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added inline comments.Aug 22 2023, 6:08 AM

native/chat/chat-input-bar.react.js
502–517	Needed to refactor this code, because of flow.
599–602	`RelativeMemberInfo` is wrapped into object, because we need to distinguish user and chat suggestions.

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 8:12 AM

• patryk published this revision for review.Aug 22 2023, 8:38 AM

item:
  | { type: 'user', user: RelativeMemberInfo }
  | { type: 'chat', chat: ResolvedThreadInfo },

Will introduce new type, which will be reused in getMentionTypeahead(User/Chat)Suggestions.

Rebase and match new refactored component style

Harbormaster completed remote builds in B22068: Diff 30292.Aug 24 2023, 2:07 PM

otherwise default_text is rendered.

Can you explain what this means, and point me to where it is done?

In D8909#265267, @inka wrote:

otherwise default_text is rendered.

Can you explain what this means, and point me to where it is done?

It is done by our markdown rules. Second to last sentence in summary is a little bit confusing regarding this diff. Will delete it!

Add read-only type

Change chat to threadInfo

Harbormaster completed remote builds in B22262: Diff 30559.Aug 30 2023, 7:47 AM

Harbormaster completed remote builds in B22265: Diff 30562.Aug 30 2023, 8:03 AM

• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 5:37 AM

inka accepted this revision.Sep 6 2023, 2:12 AM

This revision is now accepted and ready to land.Sep 6 2023, 2:12 AM

tomek added inline comments.Sep 12 2023, 8:27 AM

native/utils/typeahead-utils.js
71–73 ↗	(On Diff #30562)	As mentioned https://phab.comm.dev/D8945#inline-58298 we should extract this to a function
76–87 ↗	(On Diff #30562)	Can we avoid duplicating the code?

• patryk mentioned this in D8897: [native] Refactor TypeaheadTooltip component.Sep 19 2023, 2:44 AM

Extract mention text to separate function and apply DRY rule

Harbormaster completed remote builds in B22717: Diff 31253.Sep 19 2023, 3:41 AM

Closed by commit rCOMM569949568558: [native] Replace chat name with raw chat mention (authored by • patryk). · Explain WhySep 28 2023, 5:30 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM569949568558: [native] Replace chat name with raw chat mention.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

56 lines

Diff 30215

native/chat/chat-input-bar.react.js

	// @flow			// @flow

	import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';			import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
				import invariant from 'invariant';
	import * as React from 'react';			import * as React from 'react';
	import { Text } from 'react-native';			import { Alert, Text } from 'react-native';
	import { TouchableOpacity } from 'react-native-gesture-handler';			import { TouchableOpacity } from 'react-native-gesture-handler';

				import type { NavigationRoute } from '../navigation/route-names';
	import { useColors } from '../themes/colors.js';			import { useColors } from '../themes/colors.js';

	type Props = React.ElementConfig<typeof BaseHeaderBackButton>;			type ChangeRolesHeaderLeftButtonProps = {
	function ChangeRolesHeaderLeftButton(props: Props): React.Node {			+route: NavigationRoute<'ChangeRolesScreen'>,
				...React.ElementConfig<typeof BaseHeaderBackButton>,
				};

				function ChangeRolesHeaderLeftButton(
				props: ChangeRolesHeaderLeftButtonProps,
				): React.Node {
				const { memberInfo, role: selectedRole } = props.route.params;
				const { role: memberRole } = memberInfo;

				const onCancel = React.useCallback(() => {
				const { onPress } = props;
				invariant(onPress, 'onPress must be defined');

				if (selectedRole === memberRole) {
				onPress();
				return;
				}

				Alert.alert(
				'Unsaved Changes',
				'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
				[
				{ text: 'Cancel', onPress },
				{ text: 'Stay', style: 'cancel' },
				],
				{ cancelable: true },
				);
				}, [memberRole, props, selectedRole]);
				rohanAuthorUnsubmitted Done Inline Actions I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes. Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted) rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
				ashoatUnsubmitted Not Done Inline Actions What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
				rohanAuthorUnsubmitted Done Inline Actions Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues editing while `Discard edit` closes the alert and exits editing rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
				ashoatUnsubmitted Not Done Inline Actions I agree we shouldn't use the term `Cancel` here... how about `Leave`? I don't think we need `{ cancelable: true }`... we can just default to `Stay` if the user dismisses the `Alert` Can we try to match copy for title / description with the edit-message workflow? ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
				rohanAuthorUnsubmitted Done Inline Actions Yeah that makes sense, I'll update the diff rohan: Yeah that makes sense, I'll update the diff

	const { panelForegroundSecondaryLabel } = useColors();			const { panelForegroundSecondaryLabel } = useColors();
	const labelStyle = React.useMemo(			const labelStyle = React.useMemo(
	() => ({			() => ({
	color: panelForegroundSecondaryLabel,			color: panelForegroundSecondaryLabel,
	marginLeft: 10,			marginLeft: 10,
	}),			}),
	[panelForegroundSecondaryLabel],			[panelForegroundSecondaryLabel],
	);			);

	return (			return (
	<TouchableOpacity onPress={props.onPress}>			<TouchableOpacity onPress={onCancel}>
	<Text style={labelStyle}>Cancel</Text>			<Text style={labelStyle}>Cancel</Text>
	</TouchableOpacity>			</TouchableOpacity>
	);			);
	}			}

	export default ChangeRolesHeaderLeftButton;			export default ChangeRolesHeaderLeftButton;