Page MenuHomePhabricator
Differential D8844

[native] Refactor markdown-link component
ClosedPublic
Actions

Authored by • patryk on Aug 17 2023, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:05 PM
Unknown Object (File)
Mon, Mar 17, 4:32 AM
Unknown Object (File)
Mon, Mar 17, 4:30 AM
Unknown Object (File)
Mon, Mar 3, 9:06 PM
Unknown Object (File)
Mon, Mar 3, 2:33 PM
Unknown Object (File)
Tue, Feb 25, 5:29 PM
Unknown Object (File)
Tue, Feb 25, 5:29 PM
Unknown Object (File)
Tue, Feb 25, 5:29 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM1430543adb94: [native] Refactor markdown-link component
Summary

This diff extracts markdown-link.react.js code to markdown-utils.js. This code is going to be reused in markdown-chat-mention component.

Depends on D8834.

Test Plan

Tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 17 2023, 1:55 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 1:55 AM
Harbormaster completed remote builds in B21827: Diff 29999.Aug 17 2023, 2:12 AM
• patryk updated this revision to Diff 30008.Aug 17 2023, 6:57 AM

Change shouldBePressable logic

Harbormaster completed remote builds in B21836: Diff 30008.Aug 17 2023, 7:14 AM
• patryk edited the summary of this revision. (Show Details)Aug 18 2023, 6:08 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 9:52 AM
• patryk added a child revision: D8845: [native] Introduce markdown component for chat mentions.
• patryk added a child revision: D8871: [web][native] Refactor getDefaultTextMessageRules.Aug 19 2023, 3:22 PM
• patryk removed a child revision: D8871: [web][native] Refactor getDefaultTextMessageRules.Aug 19 2023, 3:25 PM
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 6:28 AM
• patryk added a parent revision: D8834: [lib] Introduce chat mention match and parse utilities.
• patryk published this revision for review.Aug 20 2023, 11:11 PM
inka accepted this revision.Aug 22 2023, 7:08 AM

We have an agreement in our team that if we are moving some code, we should first move it and change it in next diff, becuse moving and changing in one diff makes it hard to review. You can see in this diff that it looks on phabricator as if you removed useHandleLinkClick function, and you didn't do that

native/markdown/markdown-utils.js
20 ↗(On Diff #30008)

I'm assuming this argument will be used somewhere

60 ↗(On Diff #30008)

I think this should be () => void

This revision is now accepted and ready to land.Aug 22 2023, 7:08 AM
• patryk updated this revision to Diff 30221.Aug 22 2023, 7:09 AM

Change mixed to void

Harbormaster completed remote builds in B22010: Diff 30221.Aug 22 2023, 7:28 AM
• patryk updated this revision to Diff 30222.Aug 22 2023, 7:35 AM

Remove blockOnPress variable from useMarkdownOnPressUtils

• patryk updated this revision to Diff 30223.Aug 22 2023, 7:40 AM

Rename shouldBePressable to isRevealed

Harbormaster completed remote builds in B22011: Diff 30222.Aug 22 2023, 7:53 AM
Harbormaster completed remote builds in B22012: Diff 30223.Aug 22 2023, 7:57 AM
• patryk updated this revision to Diff 31242.Sep 19 2023, 1:30 AM

Rebase

Harbormaster completed remote builds in B22706: Diff 31242.Sep 19 2023, 1:47 AM
Closed by commit rCOMM1430543adb94: [native] Refactor markdown-link component (authored by • patryk). · Explain WhySep 28 2023, 1:16 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM1430543adb94: [native] Refactor markdown-link component.

Revision Contents
Changeset List

PathSize
native/
markdown/
97 lines
markdown-utils.js
markdown-link.react.js
80 lines

Diff 30222

View Options

native/markdown/markdown-link.react.js

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 18,637 Lines • ▼ Show 20 Linesreact-native-firebase@^5.6.0:
dependencies: dependencies:
opencollective-postinstall "^2.0.0" opencollective-postinstall "^2.0.0"
prop-types "^15.7.2" prop-types "^15.7.2"
react-native-flipper@^0.164.0, "react-native-flipper@https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz": react-native-flipper@^0.164.0, "react-native-flipper@https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz":
version "1.0.2" version "1.0.2"
resolved "https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz#77a4f0789bbd0aba4a1a19c97e03402475df02d1" resolved "https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz#77a4f0789bbd0aba4a1a19c97e03402475df02d1"
react-native-floating-action@^1.21.0: react-native-floating-action@^1.22.0:
version "1.21.0" version "1.22.0"
resolved "https://registry.yarnpkg.com/react-native-floating-action/-/react-native-floating-action-1.21.0.tgz#cb1e8349fec5b9aed06c8053c07372822c64b22f" resolved "https://registry.yarnpkg.com/react-native-floating-action/-/react-native-floating-action-1.22.0.tgz#7ec476f320e16855ad4077a3a9f36511d1718a52"
integrity sha512-ozd/iaJunrEYc4eGUWkP+4UI8yoIL0nQsToI3hnJRste/3LPhBkyu0eG3RTjc6aFY+q++JpRmgO469Ck8jJOwg== integrity sha512-m/9ueh2bgV+Dopelam2hu+FIY1wrIOPjpcBNgU3I5J9SqWmPQCarSz5L8zsW5QWE4YgXuaVbYAO/pgb0P8x/gQ==
react-native-fs@2.15.2: react-native-fs@2.15.2:
version "2.15.2" version "2.15.2"
resolved "https://registry.yarnpkg.com/react-native-fs/-/react-native-fs-2.15.2.tgz#0bb8ff3c9c4778910677f36551b3494c661453f1" resolved "https://registry.yarnpkg.com/react-native-fs/-/react-native-fs-2.15.2.tgz#0bb8ff3c9c4778910677f36551b3494c661453f1"
integrity sha512-xZ0WS5nN1IfpPKO8LpbkRPnKzZrhx7us1B2ufDnt0k40pTIJsnoQno76y/2pYQbzhXmbi3330aI4km5+akxssg== integrity sha512-xZ0WS5nN1IfpPKO8LpbkRPnKzZrhx7us1B2ufDnt0k40pTIJsnoQno76y/2pYQbzhXmbi3330aI4km5+akxssg==
dependencies: dependencies:
base-64 "^0.1.0" base-64 "^0.1.0"
utf8 "^3.0.0" utf8 "^3.0.0"
▲ Show 20 Lines • Show All 4,662 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-utils.js

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 18,637 Lines • ▼ Show 20 Linesreact-native-firebase@^5.6.0:
dependencies: dependencies:
opencollective-postinstall "^2.0.0" opencollective-postinstall "^2.0.0"
prop-types "^15.7.2" prop-types "^15.7.2"
react-native-flipper@^0.164.0, "react-native-flipper@https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz": react-native-flipper@^0.164.0, "react-native-flipper@https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz":
version "1.0.2" version "1.0.2"
resolved "https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz#77a4f0789bbd0aba4a1a19c97e03402475df02d1" resolved "https://registry.yarnpkg.com/@favware/skip-dependency/-/skip-dependency-1.0.2.tgz#77a4f0789bbd0aba4a1a19c97e03402475df02d1"
react-native-floating-action@^1.21.0: react-native-floating-action@^1.22.0:
version "1.21.0" version "1.22.0"
resolved "https://registry.yarnpkg.com/react-native-floating-action/-/react-native-floating-action-1.21.0.tgz#cb1e8349fec5b9aed06c8053c07372822c64b22f" resolved "https://registry.yarnpkg.com/react-native-floating-action/-/react-native-floating-action-1.22.0.tgz#7ec476f320e16855ad4077a3a9f36511d1718a52"
integrity sha512-ozd/iaJunrEYc4eGUWkP+4UI8yoIL0nQsToI3hnJRste/3LPhBkyu0eG3RTjc6aFY+q++JpRmgO469Ck8jJOwg== integrity sha512-m/9ueh2bgV+Dopelam2hu+FIY1wrIOPjpcBNgU3I5J9SqWmPQCarSz5L8zsW5QWE4YgXuaVbYAO/pgb0P8x/gQ==
react-native-fs@2.15.2: react-native-fs@2.15.2:
version "2.15.2" version "2.15.2"
resolved "https://registry.yarnpkg.com/react-native-fs/-/react-native-fs-2.15.2.tgz#0bb8ff3c9c4778910677f36551b3494c661453f1" resolved "https://registry.yarnpkg.com/react-native-fs/-/react-native-fs-2.15.2.tgz#0bb8ff3c9c4778910677f36551b3494c661453f1"
integrity sha512-xZ0WS5nN1IfpPKO8LpbkRPnKzZrhx7us1B2ufDnt0k40pTIJsnoQno76y/2pYQbzhXmbi3330aI4km5+akxssg== integrity sha512-xZ0WS5nN1IfpPKO8LpbkRPnKzZrhx7us1B2ufDnt0k40pTIJsnoQno76y/2pYQbzhXmbi3330aI4km5+akxssg==
dependencies: dependencies:
base-64 "^0.1.0" base-64 "^0.1.0"
utf8 "^3.0.0" utf8 "^3.0.0"
▲ Show 20 Lines • Show All 4,662 Lines • Show Last 20 Lines