Page MenuHomePhabricator
Differential D8708

[web] seperate out each reaction into their own pill
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 11:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:40 PM
Unknown Object (File)
Wed, Nov 20, 3:15 AM
Unknown Object (File)
Fri, Nov 1, 1:43 PM
Unknown Object (File)
Fri, Nov 1, 1:43 PM
Unknown Object (File)
Fri, Nov 1, 1:43 PM
Unknown Object (File)
Fri, Nov 1, 1:41 PM
Unknown Object (File)
Fri, Nov 1, 1:21 PM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill
Summary

The next step to redesigning the InlineEngagement component is to split out each reaction into its own pill.

Depends on D8707

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 2 2023, 11:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 11:57 AM
ginsu edited the summary of this revision. (Show Details)Aug 2 2023, 12:03 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8707: [web] add space between inline engagement container and edges of chat window.
ginsu attached a referenced file: F672387: Screen Recording 2023-08-02 at 3.01.58 PM.mov. (Show Details)
ginsu added inline comments.Aug 2 2023, 12:06 PM
web/chat/inline-engagement.css
67–68 ↗(On Diff #29488)

We can get rid of this because of the gap property we added above

web/chat/inline-engagement.react.js
9 ↗(On Diff #29488)

The next diff will handle cleaning up this now unused function

26 ↗(On Diff #29488)

This got moved to line 54

ginsu mentioned this in D8709: [web] deprecate stringForReactionList.Aug 2 2023, 12:09 PM
ginsu added a child revision: D8709: [web] deprecate stringForReactionList.Aug 2 2023, 12:13 PM
ginsu published this revision for review.Aug 2 2023, 12:25 PM
Harbormaster failed remote builds in B21495: Diff 29488!Aug 2 2023, 12:44 PM
atul accepted this revision.Aug 3 2023, 9:29 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:29 PM
Harbormaster completed remote builds in B21495: Diff 29488.Aug 3 2023, 9:36 PM
ginsu updated this revision to Diff 30363.Aug 27 2023, 7:49 PM

rebase before landing

Harbormaster completed remote builds in B22129: Diff 30363.Aug 27 2023, 8:06 PM
Closed by commit rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM40037ddb05fc: [web] seperate out each reaction into their own pill.

Revision Contents
Changeset List

PathSize
web/
chat/
10 lines
54 lines

Diff 30363

View Options

web/chat/inline-engagement.css

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...