Page MenuHomePhabricator
Differential D8909

[native] Replace chat name with raw chat mention
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 5:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 11:13 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
Unknown Object (File)
Sun, Dec 15, 6:26 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM569949568558: [native] Replace chat name with raw chat mention
Summary

Solution for ENG-4553 and ENG-4555.

This diff adds support for chats in mentionTypeaheadTooltipActions . Chat entry is encoded in the following convention:

@[[chat_id:default_text]]

Depends on D8908.

Test Plan

Tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 22 2023, 5:26 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 5:26 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:32 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk edited the summary of this revision. (Show Details)
• patryk added a parent revision: D8908: [lib] Encode chat name in raw chat mention.
• patryk added a child revision: D8910: [native] Show chats in mention typeahead tooltip.Aug 22 2023, 5:34 AM
Harbormaster completed remote builds in B22006: Diff 30215.Aug 22 2023, 5:43 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:51 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added inline comments.Aug 22 2023, 6:08 AM
native/chat/chat-input-bar.react.js
502–517 ↗(On Diff #30215)

Needed to refactor this code, because of flow.

599–602 ↗(On Diff #30215)

RelativeMemberInfo is wrapped into object, because we need to distinguish user and chat suggestions.

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 8:12 AM
• patryk published this revision for review.Aug 22 2023, 8:38 AM
• patryk planned changes to this revision.Aug 22 2023, 9:35 AM
item:
  | { type: 'user', user: RelativeMemberInfo }
  | { type: 'chat', chat: ResolvedThreadInfo },

Will introduce new type, which will be reused in getMentionTypeahead(User/Chat)Suggestions.

• patryk updated this revision to Diff 30292.Aug 24 2023, 1:45 PM

Rebase and match new refactored component style

Harbormaster completed remote builds in B22068: Diff 30292.Aug 24 2023, 2:07 PM
inka added a comment.Aug 29 2023, 5:47 AM

otherwise default_text is rendered.

Can you explain what this means, and point me to where it is done?

• patryk added a comment.Aug 30 2023, 12:18 AM
In D8909#265267, @inka wrote:

otherwise default_text is rendered.

Can you explain what this means, and point me to where it is done?

It is done by our markdown rules. Second to last sentence in summary is a little bit confusing regarding this diff. Will delete it!

• patryk updated this revision to Diff 30559.EditedAug 30 2023, 7:30 AM

Add read-only type

• patryk updated this revision to Diff 30562.Aug 30 2023, 7:45 AM

Change chat to threadInfo

Harbormaster completed remote builds in B22262: Diff 30559.Aug 30 2023, 7:47 AM
Harbormaster completed remote builds in B22265: Diff 30562.Aug 30 2023, 8:03 AM
• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 5:37 AM
inka accepted this revision.Sep 6 2023, 2:12 AM
This revision is now accepted and ready to land.Sep 6 2023, 2:12 AM
tomek added inline comments.Sep 12 2023, 8:27 AM
native/utils/typeahead-utils.js
71–73

As mentioned https://phab.comm.dev/D8945#inline-58298 we should extract this to a function

76–87

Can we avoid duplicating the code?

• patryk mentioned this in D8897: [native] Refactor TypeaheadTooltip component.Sep 19 2023, 2:44 AM
• patryk updated this revision to Diff 31253.Sep 19 2023, 3:24 AM

Extract mention text to separate function and apply DRY rule

Harbormaster completed remote builds in B22717: Diff 31253.Sep 19 2023, 3:41 AM
Closed by commit rCOMM569949568558: [native] Replace chat name with raw chat mention (authored by • patryk). · Explain WhySep 28 2023, 5:30 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM569949568558: [native] Replace chat name with raw chat mention.

Revision Contents
Changeset List

PathSize
lib/
shared/
10 lines
native/
chat/
10 lines
utils/
25 lines

Diff 30562

View Options

lib/shared/mention-utils.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/utils/typeahead-utils.js

Loading...