Page MenuHomePhabricator
Differential D8902

[web][native] Use userStoreMentionSearchIndex
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 5:31 PM
Unknown Object (File)
Sat, Dec 7, 11:56 AM
Unknown Object (File)
Sat, Nov 30, 1:25 AM
Unknown Object (File)
Tue, Nov 26, 7:25 PM
Unknown Object (File)
Tue, Nov 26, 5:17 PM
Unknown Object (File)
Nov 23 2024, 4:55 AM
Unknown Object (File)
Nov 23 2024, 3:44 AM
Unknown Object (File)
Nov 23 2024, 1:48 AM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM0fc0cbb6e452: [web][native] Use userStoreMentionSearchIndex
Summary

This diff replaces old userStoreSearchIndex usage in chat-input-bar.react.js with new userStoreMentionSearchIndex selector.

Depends on D8901.

Test Plan

Tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 22 2023, 2:06 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 2:06 AM
Harbormaster completed remote builds in B21984: Diff 30186.Aug 22 2023, 2:22 AM
• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 3:34 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka.
• patryk added inline comments.
native/chat/chat-input-bar.react.js
1273 ↗(On Diff #30186)

Also making this change on web -> will introduce showing chats in typeahead tooltip on web diffs soon.

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 3:35 AM
• patryk added a parent revision: D8901: [lib] Add userStoreMentionSearchIndex selector.
• patryk added a child revision: D8908: [lib] Encode chat name in raw chat mention.Aug 22 2023, 5:28 AM
• patryk added a reviewer: rohan.Aug 22 2023, 5:50 AM
• patryk published this revision for review.Aug 22 2023, 8:38 AM
• patryk updated this revision to Diff 30290.Aug 24 2023, 1:44 PM

Rebase

Harbormaster completed remote builds in B22066: Diff 30290.Aug 24 2023, 2:03 PM
inka accepted this revision.Aug 29 2023, 5:22 AM
This revision is now accepted and ready to land.Aug 29 2023, 5:22 AM
• patryk updated this revision to Diff 30685.Aug 31 2023, 11:51 PM

Rebase

Harbormaster completed remote builds in B22333: Diff 30685.Sep 1 2023, 12:09 AM
Closed by commit rCOMM0fc0cbb6e452: [web][native] Use userStoreMentionSearchIndex (authored by • patryk). · Explain WhySep 28 2023, 5:24 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM0fc0cbb6e452: [web][native] Use userStoreMentionSearchIndex.

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
native/
chat/
8 lines
web/
chat/
4 lines

Diff 30685

View Options

lib/shared/mention-utils.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...