Page MenuHomePhabricator

[client-backup] implement backup handler
ClosedPublic

Authored by kamil on Aug 29 2023, 2:52 AM.
Tags
None
Referenced Files
F3247055: D9003.id.diff
Fri, Nov 15, 3:11 AM
Unknown Object (File)
Sun, Nov 10, 12:33 PM
Unknown Object (File)
Sun, Nov 10, 12:32 PM
Unknown Object (File)
Sun, Nov 10, 6:42 AM
Unknown Object (File)
Fri, Nov 8, 1:10 PM
Unknown Object (File)
Sat, Nov 2, 12:26 PM
Unknown Object (File)
Sun, Oct 27, 4:09 PM
Unknown Object (File)
Oct 15 2024, 1:01 AM
Subscribers

Details

Summary

For now in UserData we store UserStore. Each time it changes we upload a new backup.

Depends on D9002

Test Plan

Test both successful and failed uploads.

image.png (789×391 px, 74 KB)

image.png (803×392 px, 87 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Aug 29 2023, 4:05 AM
native/backup/backup-handler.js
38 ↗(On Diff #30486)

What do you think?

54 ↗(On Diff #30486)

Even if it's opt-in we probably don't need to display the alert on success

native/backup/backup-handler.js
54 ↗(On Diff #30486)

We have so much alert spam already 😅

  • remove success info
  • rename some vars
native/backup/backup-handler.js
38 ↗(On Diff #30486)

I'm not convinced, sha256Hash is more current hash, value from AsyncStorage is recent as it was computed previously 😅

54 ↗(On Diff #30486)

okay, I wanted to check how frequent data is backed up - but we can always check this in backup service logs

michal added inline comments.
native/backup/backup-handler.js
38 ↗(On Diff #30486)

What about mostRecentlyUploadedBackupHash? :P

This revision is now accepted and ready to land.Sep 4 2023, 8:31 AM
This revision was automatically updated to reflect the committed changes.