When a device starts a session with tunnelbroker, verify
the device before continuing the session.
https://linear.app/comm/issue/ENG-3977
Depends on D8916
Details
Details
- Start identity service, tunnelbroker
cd services/commtest cargo test --test identity_tunnelbroker_tests
Should see logs in tunnelbroker that the device was autheticated successfully
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/tunnelbroker/src/identity/mod.rs | ||
|---|---|---|
| 11–27 ↗ | (On Diff #30240) | I'll likely refactor this later to be in grpc_clients, as this will be a common call from services... Done in https://phab.comm.dev/D9015 |
| services/tunnelbroker/src/config.rs | ||
|---|---|---|
| 26 ↗ | (On Diff #31124) | You can do shorter form. The default_value_t expects that you already provided correct type (String in this case) while default_value tries to convert it (&str -> String in this case) |
| services/tunnelbroker/src/identity/mod.rs | ||
| 11 ↗ | (On Diff #31124) | I remember that Jon moved this function to shared/grpc_clients/src/identity/unauthenticated/client.rs. We might want to add this crate as dependency and use it instead. You can do it in a separate diff, though. |
| 26 ↗ | (On Diff #31124) | The same comment about return as below |
| services/tunnelbroker/src/websockets/session.rs | ||
| 98 ↗ | (On Diff #31124) | I don't think you need to do return. You can check for such warnings by running Clippy linter: cargo clippy (you might need to install it) |
| services/tunnelbroker/src/websockets/session.rs | ||
|---|---|---|
| 79 ↗ | (On Diff #31124) | This should probably be error! right? |