Page MenuHomePhabricator
Differential D9254

[lib] Add unit tests for mention utils
ClosedPublic
Actions

Authored by • patryk on Sep 21 2023, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 10:11 AM
Unknown Object (File)
Thu, Mar 20, 1:45 AM
Unknown Object (File)
Mon, Mar 17, 3:22 AM
Unknown Object (File)
Mon, Mar 17, 3:21 AM
Unknown Object (File)
Feb 25 2025, 3:32 PM
Unknown Object (File)
Feb 25 2025, 7:30 AM
Unknown Object (File)
Feb 25 2025, 7:30 AM
Unknown Object (File)
Feb 25 2025, 7:30 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
rohan
Commits
rCOMMb9b07901d233: [lib] Add unit tests for mention utils
Summary

This diff introduces tests for lib/shared/mention-utils.js file.

Depends on D8908.

Test Plan

Run yarn test in lib folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mentioning-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 21 2023, 4:21 AM
• patryk held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 21 2023, 4:21 AM
• patryk edited the summary of this revision. (Show Details)Sep 21 2023, 4:22 AM
• patryk added a parent revision: D8908: [lib] Encode chat name in raw chat mention.
• patryk edited the summary of this revision. (Show Details)
• patryk updated this revision to Diff 31335.Sep 21 2023, 4:29 AM

Update text

• patryk published this revision for review.Sep 21 2023, 4:34 AM
Harbormaster completed remote builds in B22774: Diff 31333.Sep 21 2023, 4:39 AM
Harbormaster completed remote builds in B22776: Diff 31335.Sep 21 2023, 4:46 AM
• patryk mentioned this in D8908: [lib] Encode chat name in raw chat mention.Sep 21 2023, 6:24 AM
inka accepted this revision.Sep 22 2023, 7:55 AM
This revision is now accepted and ready to land.Sep 22 2023, 7:55 AM
Closed by commit rCOMMb9b07901d233: [lib] Add unit tests for mention utils (authored by • patryk). · Explain WhySep 28 2023, 5:59 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMb9b07901d233: [lib] Add unit tests for mention utils.

Revision Contents
Changeset List

PathSize
lib/
shared/
62 lines

Diff 31335

View Options

lib/shared/mention-utils.test.js

  • This file was added.
.rolePanelEntry {
display: flex;
flex-direction: row;
justify-content: space-between;
align-items: center;
padding: 12px;
color: var(--community-roles-text-color);
font-weight: 500;
}
.rolePanelNameEntry {
font-size: var(--s-font-14);
}
.rolePanelCountEntryContainer {
margin-right: 40px;
display: flex;
align-items: flex-end;
}
.rolePanelCountEntry {
font-size: var(--s-font-14);
margin-right: 2px;
}