Page MenuHomePhabricator
Differential D9254

[lib] Add unit tests for mention utils
ClosedPublic
Actions

Authored by • patryk on Sep 21 2023, 4:21 AM.
Tags
None
Referenced Files
F6305193: D9254.diff
Sat, Apr 26, 7:29 AM
F6305079: D9254.diff
Sat, Apr 26, 7:22 AM
F6305063: D9254.diff
Sat, Apr 26, 7:21 AM
Unknown Object (File)
Thu, Apr 24, 7:07 PM
Unknown Object (File)
Fri, Apr 18, 10:28 AM
Unknown Object (File)
Fri, Apr 18, 7:43 AM
Unknown Object (File)
Thu, Apr 17, 9:13 AM
Unknown Object (File)
Thu, Apr 17, 7:12 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
rohan
Commits
rCOMMb9b07901d233: [lib] Add unit tests for mention utils
Summary

This diff introduces tests for lib/shared/mention-utils.js file.

Depends on D8908.

Test Plan

Run yarn test in lib folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mentioning-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Sep 21 2023, 4:21 AM
• patryk held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 21 2023, 4:21 AM
• patryk edited the summary of this revision. (Show Details)Sep 21 2023, 4:22 AM
• patryk added a parent revision: D8908: [lib] Encode chat name in raw chat mention.
• patryk edited the summary of this revision. (Show Details)
• patryk updated this revision to Diff 31335.Sep 21 2023, 4:29 AM

Update text

• patryk published this revision for review.Sep 21 2023, 4:34 AM
Harbormaster completed remote builds in B22774: Diff 31333.Sep 21 2023, 4:39 AM
Harbormaster completed remote builds in B22776: Diff 31335.Sep 21 2023, 4:46 AM
• patryk mentioned this in D8908: [lib] Encode chat name in raw chat mention.Sep 21 2023, 6:24 AM
inka accepted this revision.Sep 22 2023, 7:55 AM
This revision is now accepted and ready to land.Sep 22 2023, 7:55 AM
Closed by commit rCOMMb9b07901d233: [lib] Add unit tests for mention utils (authored by • patryk). · Explain WhySep 28 2023, 5:59 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMb9b07901d233: [lib] Add unit tests for mention utils.

Revision Contents
Changeset List

PathSize
lib/
shared/
62 lines

Diff 31335

View Options

lib/shared/mention-utils.test.js

Show First 20 Lines • Show All 708 Lines • ▼ Show 20 Lines
): Promise< ): Promise<
$ReadOnlyMap<string, RawComposableMessageInfo | RawRobotextMessageInfo>, $ReadOnlyMap<string, RawComposableMessageInfo | RawRobotextMessageInfo>,
> { > {
const requiredIDs = new Set<string>(); const requiredIDs = new Set<string>();
for (const row of rows) { for (const row of rows) {
if (row.type === messageTypes.SIDEBAR_SOURCE) { if (row.type === messageTypes.SIDEBAR_SOURCE) {
const content = JSON.parse(row.content); const content = JSON.parse(row.content);
requiredIDs.add(content.sourceMessageID); requiredIDs.add(content.sourceMessageID);
} else if (row.type === messageTypes.TOGGLE_PIN) {
const content = JSON.parse(row.content);
requiredIDs.add(content.targetMessageID);
} }
} }
const messagesByID = new Map< const messagesByID = new Map<
string, string,
RawComposableMessageInfo | RawRobotextMessageInfo, RawComposableMessageInfo | RawRobotextMessageInfo,
>(); >();
if (requiredIDs.size === 0) { if (requiredIDs.size === 0) {
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines