Page MenuHomePhabricator
Differential D9057

[web] Add webMentionTypeaheadRegex tests
ClosedPublic
Actions

Authored by • patryk on Aug 31 2023, 2:49 PM.
Tags
None
Referenced Files
F3140562: D9057.diff
Sun, Nov 3, 4:55 AM
Unknown Object (File)
Wed, Oct 30, 10:21 PM
Unknown Object (File)
Sun, Oct 27, 2:04 PM
Unknown Object (File)
Mon, Oct 21, 4:10 AM
Unknown Object (File)
Sun, Oct 20, 5:49 AM
Unknown Object (File)
Fri, Oct 18, 1:58 AM
Unknown Object (File)
Thu, Oct 17, 11:44 PM
Unknown Object (File)
Thu, Oct 17, 10:57 PM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests
Summary

This diff adds webMentionTypeaheadRegex regex unit tests to typeahead-utils.test.js.

Depends on D9056.

Test Plan

Run yarn test in web folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mentioning-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Aug 31 2023, 2:49 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2023, 2:49 PM
• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 2:55 PM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk added a parent revision: D9056: [lib] Add unit tests for chat mention regex.
Harbormaster completed remote builds in B22329: Diff 30681.Aug 31 2023, 3:08 PM
inka mentioned this in D8834: [lib] Introduce chat mention match and parse utilities.Sep 6 2023, 2:37 AM
• patryk updated this revision to Diff 31337.Sep 21 2023, 7:47 AM

Add more tests

• patryk updated this revision to Diff 31338.Sep 21 2023, 7:52 AM

Change text

• patryk published this revision for review.Sep 21 2023, 7:53 AM
Harbormaster completed remote builds in B22778: Diff 31337.Sep 21 2023, 8:06 AM
Harbormaster completed remote builds in B22779: Diff 31338.Sep 21 2023, 8:09 AM
inka accepted this revision.Sep 22 2023, 6:45 AM
This revision is now accepted and ready to land.Sep 22 2023, 6:45 AM
• patryk mentioned this in D8944: [web] Modify mention typeahead regex.Sep 22 2023, 7:29 AM
inka added a comment.Sep 22 2023, 7:32 AM

You could remove the text field and just do textPrefix + mentionText

• patryk updated this revision to Diff 31371.Sep 22 2023, 7:44 AM

Simplify test cases

Harbormaster completed remote builds in B22803: Diff 31371.Sep 22 2023, 8:02 AM
Closed by commit rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests (authored by • patryk). · Explain WhySep 28 2023, 5:59 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests.

Revision Contents
Changeset List

PathSize
web/
utils/
77 lines

Diff 31338

View Options

web/utils/typeahead-utils.test.js

Loading...