[lib] Update `convertRawThreadInfoToClientDBThreadInfo` to handle `RawThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 5 2023, 12:47 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM00f1163d1b44: [lib] Update `convertRawThreadInfoToClientDBThreadInfo` to handle…

Summary

Basically modify function to pull out minimallyEncoded field before converting to ClientDBThreadInfo representation. This is fine because all of the columns in the SQLite database are compatible with the new "shape" of the data here.

Unfortunately, we can't do this as easily with convertClientDBThreadInfoToRawThreadInfo because it's used as part of migrations so we don't want to change the behavior of those migrations for users upgrading from an older version. Will have to create a "legacy" version of that function so migration functionality is retained.

Depends on D10197

Test Plan

CI/flow/etc

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 5 2023, 12:47 PM

atul published this revision for review.Dec 5 2023, 12:55 PM

Harbormaster completed remote builds in B24813: Diff 34319.Dec 5 2023, 1:05 PM

Yeah, we'll need to think through migrations carefully. We'll also need to migrate all of the data in SQLite from the old format to the new, right?

This revision is now accepted and ready to land.Dec 5 2023, 7:35 PM

atul added a child revision: D10209: [lib] Remove simple usages of `LegacyRawThreadInfo`.Dec 6 2023, 1:00 PM

atul mentioned this in D10210: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.Dec 6 2023, 2:28 PM

rebase and land noop refactors

In D10198#296251, @ashoat wrote:

Yeah, we'll need to think through migrations carefully. We'll also need to migrate all of the data in SQLite from the old format to the new, right?

Yeah there's a Redux migration later in the stack that handles this

Harbormaster completed remote builds in B24944: Diff 34479.Dec 11 2023, 10:17 AM

Closed by commit rCOMM00f1163d1b44: [lib] Update `convertRawThreadInfoToClientDBThreadInfo` to handle… (authored by atul). · Explain WhyDec 11 2023, 10:22 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM00f1163d1b44: [lib] Update `convertRawThreadInfoToClientDBThreadInfo` to handle….

atul mentioned this in rCOMM6b29dad3100d: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.Dec 13 2023, 1:34 PM