[native] implement accepting `olm` session
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 5:49 AM.

Details

Reviewers

Commits

Summary

Code which receive response from Tunnelbroker with session creation request, calls Identity to get Inbound keys and creates session.

Depends on D10379

Test Plan

Call this method and verify result

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil published this revision for review.Dec 18 2023, 6:54 AM

native/utils/crypto-utils.js
63	Can you split this string so the lines stay to 80 char width?

This diff looks fine in terms of the inbound session creation itself. Wondering what is our approach to handle session creation failure.

native/handlers/peer-to-peer-message-handler.js
20	Do we have a plan to inform the other peer that we failed to create inbound session? Alternatively is there a mechanism that will prevent them from sending us encrypted messages we won't be able to decrypt?

This revision is now accepted and ready to land.Jan 4 2024, 3:39 AM

make lines 80 char width

native/handlers/peer-to-peer-message-handler.js
20	yes, it's described in here - that's the place when this client should inform other peers about a failure, ask for a new session and re-send all messages