Paths

Table of Contentst

Differential D10484

[lib][web][native] Create defaultKeyserverInfo
ClosedPublic
Actions

Authored by inka on Dec 29 2023, 5:20 AM.

Tags

None

Referenced Files

	F3350177: D10484.id35083.diff
	Fri, Nov 22, 9:09 PM

	F3349073: D10484.diff
	Fri, Nov 22, 5:02 PM

	Unknown Object (File)
	Tue, Nov 5, 8:49 AM

	Unknown Object (File)
	Oct 16 2024, 3:26 AM

	Unknown Object (File)
	Oct 16 2024, 3:26 AM

	Unknown Object (File)
	Oct 16 2024, 3:26 AM

	Unknown Object (File)
	Oct 16 2024, 3:25 AM

	Unknown Object (File)
	Oct 16 2024, 3:25 AM

View All 57 Files

Subscribers

Details

Reviewers

ginsu
michal
kamil

Commits

rCOMM13d2168594ae: [lib][web][native] Create defaultKeyserverInfo

Summary

issue: https://linear.app/comm/issue/ENG-6299/save-new-keyserver-on-set-new-session
I will need this value in yet another place so I think it makes sense to extrac it

Test Plan

Tested that add it's still possible to add a keyserver, and the entry looks like it did before

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Dec 29 2023, 5:20 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 5:20 AM

inka added a child revision: D10485: [lib] Add keyserver to the store on set new session.Dec 29 2023, 5:28 AM

Harbormaster completed remote builds in B25393: Diff 35083.Dec 29 2023, 5:40 AM

inka requested review of this revision.Dec 29 2023, 5:40 AM

seems reasonable, thanks for factoring that out!

This revision is now accepted and ready to land.Dec 29 2023, 12:31 PM

michal accepted this revision.Jan 2 2024, 5:01 AM

michal added inline comments.

lib/types/keyserver-types.js
27	This feels a bit hacky, setting it to a temporary, empty string. Maybe we could make it a function that takes `urlPrefix` as a parameter?

tomek added inline comments.Jan 7 2024, 11:46 PM

lib/types/keyserver-types.js
27	Not sure if this is the right solution, but if the intention is to skip the `urlPrefix` field, we can consider changing the type to `Omit<KeyserverInfo, 'urlPrefix'>`.

Turn into a function, use in default states

Harbormaster failed remote builds in B25669: Diff 35492!Jan 10 2024, 7:01 AM

Harbormaster completed remote builds in B25669: Diff 35492.Jan 15 2024, 12:52 AM

inka added a child revision: D10603: [lib][web][native] Make possible to log out of one keyserver / delete account on one keyserver.Jan 15 2024, 1:43 AM

inka added a parent revision: D10590: [lib][native] Handle invalidSessionRecovery for keyserver auth.

Closed by commit rCOMM13d2168594ae: [lib][web][native] Create defaultKeyserverInfo (authored by inka). · Explain WhyJan 16 2024, 1:52 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM13d2168594ae: [lib][web][native] Create defaultKeyserverInfo.

inka removed a child revision: D10485: [lib] Add keyserver to the store on set new session.Jan 24 2024, 1:43 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

keyserver-types.js

18 lines

native/

profile/

add-keyserver.react.js

8 lines

web/

modals/

keyserver-selection/

add-keyserver-modal.react.js

8 lines

Diff 35083

lib/types/keyserver-types.js

Loading...

native/profile/add-keyserver.react.js

Loading...

web/modals/keyserver-selection/add-keyserver-modal.react.js

Loading...