Page MenuHomePhabricator
Differential D10550

[CommRustModule] improve params capturing
ClosedPublic
Actions

Authored by kamil on Jan 5 2024, 2:22 AM.
Tags
None
Referenced Files
F5260434: D10550.diff
Sun, Apr 6, 12:54 PM
Unknown Object (File)
Wed, Apr 2, 11:14 PM
Unknown Object (File)
Mar 6 2025, 3:05 AM
Unknown Object (File)
Mar 4 2025, 3:51 PM
Unknown Object (File)
Feb 20 2025, 6:14 PM
Unknown Object (File)
Feb 20 2025, 6:14 PM
Unknown Object (File)
Feb 20 2025, 6:14 PM
Unknown Object (File)
Feb 20 2025, 6:14 PM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
michal
Commits
rCOMMe8b3f7e5a138: [CommRustModule] improve params capturing
Summary

Addresses https://phab.comm.dev/D10510#inline-64080.

Alternative is using std::shared_ptr, but I don't think is safe because as far as I know jsi::* objects lifetime is managed by the JavaScript runtime, is tied to the JavaScript garbage collector, not by C++ here itself, so I am afraid it could potentially lead to dangling pointers.

Depends on D10530

Test Plan

Test entire stack (it uses methods here).

Diff Detail

Repository
rCOMM Comm
Branch
publish-olm-stack-3
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
233 lines

Diff 35282

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
leaveThreadActionTypes, leaveThreadActionTypes,
useLeaveThread, useLeaveThread,
} from 'lib/actions/thread-actions.js'; } from 'lib/actions/thread-actions.js';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/swmansion-icon.react.js'; import SWMansionIcon from 'lib/components/swmansion-icon.react.js';
import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js'; import { usePromoteSidebar } from 'lib/hooks/promote-sidebar.react.js';
import { childThreadInfos } from 'lib/selectors/thread-selectors.js'; import { childThreadInfos } from 'lib/selectors/thread-selectors.js';
import { import {
threadHasPermission,
threadIsChannel, threadIsChannel,
useThreadHasPermission,
viewerIsMember, viewerIsMember,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypes } from 'lib/types/thread-types-enum.js'; import { threadTypes } from 'lib/types/thread-types-enum.js';
import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js'; import { useDispatchActionPromise } from 'lib/utils/redux-promise-utils.js';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 106 Lines • ▼ Show 20 Lines return (
key="sidebars" key="sidebars"
text="Threads" text="Threads"
icon="arrow-right" icon="arrow-right"
onClick={onClickSidebars} onClick={onClickSidebars}
/> />
); );
}, [hasSidebars, onClickSidebars]); }, [hasSidebars, onClickSidebars]);
const canCreateSubchannels = React.useMemo( const canCreateSubchannels = useThreadHasPermission(
() => threadHasPermission(threadInfo, threadPermissions.CREATE_SUBCHANNELS), threadInfo,
[threadInfo], threadPermissions.CREATE_SUBCHANNELS,
); );
const hasSubchannels = React.useMemo(() => { const hasSubchannels = React.useMemo(() => {
return !!childThreads?.some(threadIsChannel); return !!childThreads?.some(threadIsChannel);
}, [childThreads]); }, [childThreads]);
const onClickViewSubchannels = React.useCallback( const onClickViewSubchannels = React.useCallback(
() => () =>
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Lines () =>
threadInfo={threadInfo} threadInfo={threadInfo}
onClose={popModal} onClose={popModal}
onConfirm={onConfirmLeaveThread} onConfirm={onConfirmLeaveThread}
/>, />,
), ),
[popModal, onConfirmLeaveThread, pushModal, threadInfo], [popModal, onConfirmLeaveThread, pushModal, threadInfo],
); );
const leaveThreadItem = React.useMemo(() => { const canLeaveThread = useThreadHasPermission(
const canLeaveThread = threadHasPermission(
threadInfo, threadInfo,
threadPermissions.LEAVE_THREAD, threadPermissions.LEAVE_THREAD,
); );
const leaveThreadItem = React.useMemo(() => {
if (!viewerIsMember(threadInfo) || !canLeaveThread) { if (!viewerIsMember(threadInfo) || !canLeaveThread) {
return null; return null;
} }
return ( return (
<MenuItem <MenuItem
key="leave" key="leave"
text="Leave chat" text="Leave chat"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo, canLeaveThread]);
const onClickPromoteSidebarToThread = React.useCallback( const onClickPromoteSidebarToThread = React.useCallback(
() => () =>
pushModal( pushModal(
<SidebarPromoteModal <SidebarPromoteModal
threadInfo={threadInfo} threadInfo={threadInfo}
onClose={popModal} onClose={popModal}
onConfirm={onPromoteSidebar} onConfirm={onPromoteSidebar}
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines