Paths

Table of Contentst

-
native/
-
cpp/CommonCpp/CryptoTools/
-
CommonCpp/
-
CryptoTools/
2/3
CryptoModule.h
-
utils/
2/3
crypto-utils.js

[native] implement creating `olm` session with own devices
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 5:50 AM.

Details

Reviewers

marcin
varun
michal

Commits

rCOMMc0fd60b4f0e7: [native] implement creating `olm` session with own devices

Summary

Code that fetches all devices of the user, creates outbound session with each of them, and sends an encrypted message via Tunnelbroker

Depends on D10380

Test Plan

Call this method and verify result

Diff Detail

Repository

rCOMM Comm

Branch

publish-olm-stack-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 5:50 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 5:50 AM

kamil added a child revision: D10382: [native] add button to test creating olm session with own devices.Dec 18 2023, 5:58 AM

kamil published this revision for review.Dec 18 2023, 6:54 AM

Harbormaster completed remote builds in B25180: Diff 34795.Dec 18 2023, 7:23 AM

ashoat added inline comments.Dec 18 2023, 11:10 AM

native/utils/crypto-utils.js
160 ↗	(On Diff #34795)	Can you split this string so the lines stay to 80 char width?

marcin added inline comments.Jan 4 2024, 3:53 AM

native/utils/crypto-utils.js
123 ↗	(On Diff #34795)	I discussed with @kamil what happens if we call this method and session with a certain user already exists. I was told that an error will be thrown. This isn't desired behaviour since we have no way to recover but log-out if a session with a user gets corrupted. We need a way to decide for each user we attempt to create session with whether the desired behaviour if session exists is an error or overwrite.

ashoat added inline comments.Jan 4 2024, 9:54 AM

native/utils/crypto-utils.js
123 ↗	(On Diff #34795)	The desired behavior is overwrite and resend unconfirmed messages. More details in ENG-6313, but unfortunately we won't be able to get the error handling side figured out as part of this month's work. Perhaps we could default to "overwrite" and handle the resending of unconfirmed messages later?

marcin added inline comments.Jan 8 2024, 2:54 AM

native/utils/crypto-utils.js
123 ↗	(On Diff #34795)	Perhaps we could default to "overwrite" and handle the resending of unconfirmed messages later? This should be one line change: https://github.com/CommE2E/comm/blob/master/native/cpp/CommonCpp/CryptoTools/CryptoModule.h#L61

overwrite session by default
make lines 80 char width

kamil added inline comments.Jan 9 2024, 2:08 AM

native/utils/crypto-utils.js
123 ↗	(On Diff #34795)	Perhaps we could default to "overwrite" and handle the resending of unconfirmed messages later? Yeah, let's do it

Harbormaster completed remote builds in B25622: Diff 35421.Jan 9 2024, 2:26 AM

marcin accepted this revision.Jan 9 2024, 3:05 AM

This revision is now accepted and ready to land.Jan 9 2024, 3:05 AM

Closed by commit rCOMMc0fd60b4f0e7: [native] implement creating `olm` session with own devices (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc0fd60b4f0e7: [native] implement creating `olm` session with own devices.

varun mentioned this in D10581: [native] identityRegisterUsernameAccount function.Jan 16 2024, 10:11 PM

kamil mentioned this in D10662: [web] Introduce deviceID parameter to initial notif message function.Jan 18 2024, 10:36 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

CryptoModule.h

2 lines

utils/

crypto-utils.js

94 lines

Diff 35421

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Show All 16 Lines

import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js';		import type { TagFarcasterChannelNavigationProp } from './tag-farcaster-channel-navigator.react.js';
import RegistrationButton from '../../account/registration/registration-button.react.js';		import RegistrationButton from '../../account/registration/registration-button.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js';		import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { type NavigationRoute } from '../../navigation/route-names.js';		import { type NavigationRoute } from '../../navigation/route-names.js';
import { useSelector } from '../../redux/redux-utils.js';		import { useSelector } from '../../redux/redux-utils.js';
import { useStyles, useColors } from '../../themes/colors.js';		import { useStyles, useColors } from '../../themes/colors.js';

		const tagFarcasterErrorMessages: { +[string]: string } = {
		already_in_use: 'This Farcaster channel is already tagged to a community.',
		ginsuAuthorUnsubmitted Done Inline Actions This copy needs to be reviewed ginsu: This copy needs to be reviewed
		};

export type TagFarcasterChannelParams = {		export type TagFarcasterChannelParams = {
+communityID: string,		+communityID: string,
};		};

type Props = {		type Props = {
+navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>,		+navigation: TagFarcasterChannelNavigationProp<'TagFarcasterChannel'>,
+route: NavigationRoute<'TagFarcasterChannel'>,		+route: NavigationRoute<'TagFarcasterChannel'>,
};		};
Show All 12 Lines	function TagFarcasterChannel(props: Props): React.Node {

const [selectedChannel, setSelectedChannel] =		const [selectedChannel, setSelectedChannel] =
React.useState<?FarcasterChannel>(null);		React.useState<?FarcasterChannel>(null);

const [channelOptions, setChannelOptions] = React.useState<		const [channelOptions, setChannelOptions] = React.useState<
$ReadOnlyArray<FarcasterChannel>,		$ReadOnlyArray<FarcasterChannel>,
>([]);		>([]);

		const [error, setError] = React.useState<?string>(null);

const neynarClientContext = React.useContext(NeynarClientContext);		const neynarClientContext = React.useContext(NeynarClientContext);
invariant(neynarClientContext, 'NeynarClientContext is missing');		invariant(neynarClientContext, 'NeynarClientContext is missing');

const { client } = neynarClientContext;		const { client } = neynarClientContext;

React.useEffect(() => {		React.useEffect(() => {
void (async () => {		void (async () => {
const channels = await client.fetchFollowedFarcasterChannels(fid);		const channels = await client.fetchFollowedFarcasterChannels(fid);
Show All 19 Lines	(selectedIndex: ?number) => {
}		}

setSelectedChannel(channelOptions[selectedIndex]);		setSelectedChannel(channelOptions[selectedIndex]);
},		},
[channelOptions],		[channelOptions],
);		);

const onPressSelectChannel = React.useCallback(() => {		const onPressSelectChannel = React.useCallback(() => {
		setError(null);
		inkaUnsubmitted Not Done Inline Actions Can we move this to `onOptionSelected`? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked inka: Can we move this to `onOptionSelected`? If you disagree I won't insist, but it seems more…

const channelNames = channelOptions.map(channel => channel.name);		const channelNames = channelOptions.map(channel => channel.name);

const options =		const options =
Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames;		Platform.OS === 'ios' ? [...channelNames, 'Cancel'] : channelNames;

const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1;		const cancelButtonIndex = Platform.OS === 'ios' ? options.length - 1 : -1;

const containerStyle = {		const containerStyle = {
Show All 28 Lines	const createCreateOrUpdateActionPromise = React.useCallback(async () => {
}		}

try {		try {
return await createOrUpdateFarcasterChannelTag({		return await createOrUpdateFarcasterChannelTag({
commCommunityID: communityID,		commCommunityID: communityID,
farcasterChannelID: selectedChannel.id,		farcasterChannelID: selectedChannel.id,
});		});
} catch (e) {		} catch (e) {
console.log('error', e); // TODO: Improve error handling		setError(e.message);
throw e;		throw e;
}		}
}, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]);		}, [communityID, createOrUpdateFarcasterChannelTag, selectedChannel]);

const onPressTag = React.useCallback(() => {		const onPressTag = React.useCallback(() => {
void dispatchActionPromise(		void dispatchActionPromise(
createOrUpdateFarcasterChannelTagActionTypes,		createOrUpdateFarcasterChannelTagActionTypes,
createCreateOrUpdateActionPromise(),		createCreateOrUpdateActionPromise(),
);		);
}, [createCreateOrUpdateActionPromise, dispatchActionPromise]);		}, [createCreateOrUpdateActionPromise, dispatchActionPromise]);

const channelSelectionStyles = React.useMemo(		const channelSelectionStyles = React.useMemo(
() => [styles.sectionContainer, styles.touchableSectionContainer],		() => [styles.sectionContainer, styles.touchableSectionContainer],
[styles.sectionContainer, styles.touchableSectionContainer],		[styles.sectionContainer, styles.touchableSectionContainer],
);		);

		const errorMessage = React.useMemo(() => {
		if (!error) {
		return null;
		}

		return (
		<Text style={styles.error}>
		{tagFarcasterErrorMessages[error] ?? 'Unknown error.'}
		ginsuAuthorUnsubmitted Done Inline Actions Copy needs to be reviewed ginsu: Copy needs to be reviewed
		</Text>
		);
		}, [error, styles.error]);

const channelSelectionTextContent = selectedChannel?.name		const channelSelectionTextContent = selectedChannel?.name
? selectedChannel.name		? selectedChannel.name
: 'No Farcaster channel tagged';		: 'No Farcaster channel tagged';

const buttonVariant = selectedChannel ? 'enabled' : 'disabled';		const buttonVariant = selectedChannel ? 'enabled' : 'disabled';

const tagFarcasterChannel = React.useMemo(		const tagFarcasterChannel = React.useMemo(
() => (		() => (
Show All 10 Lines	() => (
>		>
<Text style={styles.sectionText}>{channelSelectionTextContent}</Text>		<Text style={styles.sectionText}>{channelSelectionTextContent}</Text>
<SWMansionIcon		<SWMansionIcon
name="edit-1"		name="edit-1"
size={20}		size={20}
color={colors.panelForegroundSecondaryLabel}		color={colors.panelForegroundSecondaryLabel}
/>		/>
</TouchableOpacity>		</TouchableOpacity>
		<View style={styles.errorContainer}>{errorMessage}</View>
<RegistrationButton		<RegistrationButton
onPress={onPressTag}		onPress={onPressTag}
label="Tag channel"		label="Tag channel"
variant={buttonVariant}		variant={buttonVariant}
/>		/>
</View>		</View>
),		),
[		[
styles.sectionContainer,		styles.sectionContainer,
styles.sectionText,		styles.sectionText,
styles.sectionHeaderText,		styles.sectionHeaderText,
		styles.errorContainer,
channelSelectionStyles,		channelSelectionStyles,
onPressSelectChannel,		onPressSelectChannel,
channelSelectionTextContent,		channelSelectionTextContent,
colors.panelForegroundSecondaryLabel,		colors.panelForegroundSecondaryLabel,
		errorMessage,
onPressTag,		onPressTag,
buttonVariant,		buttonVariant,
],		],
);		);

return tagFarcasterChannel;		return tagFarcasterChannel;
}		}

Show All 15 Lines	sectionHeaderText: {
paddingHorizontal: 16,		paddingHorizontal: 16,
paddingBottom: 4,		paddingBottom: 4,
},		},
touchableSectionContainer: {		touchableSectionContainer: {
flexDirection: 'row',		flexDirection: 'row',
justifyContent: 'space-between',		justifyContent: 'space-between',
alignItems: 'center',		alignItems: 'center',
},		},
		errorContainer: {
		height: 18,
		},
		error: {
		fontSize: 12,
		fontWeight: '400',
		lineHeight: 18,
		textAlign: 'center',
		color: 'redText',
		},
};		};

export default TagFarcasterChannel;		export default TagFarcasterChannel;