Paths

Table of Contentst

-
services/commtest/src/identity/
-
commtest/
-
src/
-
identity/
-
device.rs

[commtest] Add functions to login/logout existing username
ClosedPublic
Actions

Authored by bartek on Dec 21 2023, 2:12 AM.

Details

Reviewers

kamil
michal
varun

Commits

rCOMM231725810f64: [commtest] Add functions to login/logout existing username

Summary

The register_user_device (formerly create_device()) always registers a new user.
To manage device list, we need functions to login/logout devices of existing user.
Created functions that call Login and Logout identity RPCs.

Depends on D10420

Test Plan

Commtest builds, CI passes.
Functions' logic tested in the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 21 2023, 2:12 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 2:12 AM

bartek added a child revision: D10422: [commtest] Add tests for Identity device list.Dec 21 2023, 2:15 AM

Harbormaster completed remote builds in B25262: Diff 34895.Dec 21 2023, 3:21 AM

bartek published this revision for review.Dec 21 2023, 3:45 AM

Looks exactly like the implementation from native_rust_library which works, LGTM

services/commtest/src/identity/device.rs
114 ↗	(On Diff #34895)	probably you meant `Login`?

This revision is now accepted and ready to land.Jan 5 2024, 1:54 AM

bartek added inline comments.Jan 5 2024, 2:01 AM

services/commtest/src/identity/device.rs
114 ↗	(On Diff #34895)	Yes 😅
114–117 ↗	(On Diff #34895)

Rebase. Address feedback

Harbormaster completed remote builds in B25630: Diff 35429.Jan 9 2024, 6:15 AM

Closed by commit rCOMM231725810f64: [commtest] Add functions to login/logout existing username (authored by bartek). · Explain WhyJan 9 2024, 6:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM231725810f64: [commtest] Add functions to login/logout existing username.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

device.rs

120 lines

Diff 35429

View Options

services/commtest/src/identity/device.rs

Show All 20 Lines	import {
type EditMessageContent,		type EditMessageContent,
type MessageSelectionCriteria,		type MessageSelectionCriteria,
type MessageTruncationStatus,		type MessageTruncationStatus,
messageTruncationStatus,		messageTruncationStatus,
type FetchMessageInfosResult,		type FetchMessageInfosResult,
defaultMaxMessageAge,		defaultMaxMessageAge,
type FetchPinnedMessagesRequest,		type FetchPinnedMessagesRequest,
type FetchPinnedMessagesResult,		type FetchPinnedMessagesResult,
isMessageSidebarSourceReactionOrEdit,		isMessageSidebarSourceReactionEditOrPin,
type SearchMessagesResponse,		type SearchMessagesResponse,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultNumberPerThread } from 'lib/types/message-types.js';		import { defaultNumberPerThread } from 'lib/types/message-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';

import {		import {
constructMediaFromMediaMessageContentsAndUploadRows,		constructMediaFromMediaMessageContentsAndUploadRows,
▲ Show 20 Lines • Show All 702 Lines • ▼ Show 20 Lines	const [result, edits] = await Promise.all([
fetchMessageRowsByIDs([...requiredIDs]),		fetchMessageRowsByIDs([...requiredIDs]),
fetchLatestEditMessageContentByIDs([...requiredIDs]),		fetchLatestEditMessageContentByIDs([...requiredIDs]),
]);		]);
const messages = await parseMessageSQLResult(result, new Map(), viewer);		const messages = await parseMessageSQLResult(result, new Map(), viewer);

for (const message of messages) {		for (const message of messages) {
let { rawMessageInfo } = message;		let { rawMessageInfo } = message;
invariant(		invariant(
!isMessageSidebarSourceReactionOrEdit(rawMessageInfo),		!isMessageSidebarSourceReactionEditOrPin(rawMessageInfo),
'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +		'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +
'SIDEBAR_SOURCE, REACTION or EDIT_MESSAGE',		'SIDEBAR_SOURCE, REACTION, EDIT_MESSAGE or TOGGLE_PIN',
);		);
if (rawMessageInfo.id) {		if (rawMessageInfo.id) {
const editedContent = edits.get(rawMessageInfo.id);		const editedContent = edits.get(rawMessageInfo.id);
if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {		if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {
rawMessageInfo = {		rawMessageInfo = {
...rawMessageInfo,		...rawMessageInfo,
text: editedContent.text,		text: editedContent.text,
};		};
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	const query = SQL`
FROM messages m		FROM messages m
LEFT JOIN uploads up ON up.container = m.id		LEFT JOIN uploads up ON up.container = m.id
LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}		LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}
AND stm.thread = m.content AND stm.user = m.user		AND stm.thread = m.content AND stm.user = m.user
WHERE m.target_message IN (${originalMessageIDs})		WHERE m.target_message IN (${originalMessageIDs})
AND (		AND (
m.type = ${messageTypes.SIDEBAR_SOURCE}		m.type = ${messageTypes.SIDEBAR_SOURCE}
OR m.type = ${messageTypes.REACTION}		OR m.type = ${messageTypes.REACTION}
		OR m.type = ${messageTypes.TOGGLE_PIN}
)		)
UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,		UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,
m.creation, m.user AS creatorID, m.target_message as targetMessageID,		m.creation, m.user AS creatorID, m.target_message as targetMessageID,
stm.permissions AS subthread_permissions, up.id AS uploadID,		stm.permissions AS subthread_permissions, up.id AS uploadID,
up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra		up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra
FROM messages m2		FROM messages m2
INNER JOIN messages m ON m.id = (		INNER JOIN messages m ON m.id = (
SELECT m3.id FROM messages m3		SELECT m3.id FROM messages m3
Show All 24 Lines
): Promise<$ReadOnlyArray<RawMessageInfo>> {		): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);		const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<		const rawMessageInfoMap = new Map<
string,		string,
RawComposableMessageInfo \| RawRobotextMessageInfo,		RawComposableMessageInfo \| RawRobotextMessageInfo,
>();		>();
for (const message of parsedResults) {		for (const message of parsedResults) {
const { rawMessageInfo } = message;		const { rawMessageInfo } = message;
if (isMessageSidebarSourceReactionOrEdit(rawMessageInfo)) {		if (isMessageSidebarSourceReactionEditOrPin(rawMessageInfo)) {
continue;		continue;
}		}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');		invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);		rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}		}

const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);		const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(		const rawRelatedMessageInfos = await fetchRelatedMessages(
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

[commtest] Add functions to login/logout existing usernameClosedPublicActions