Page MenuHomePhabricator
Differential D10620

[lib] Refactor thread reducer
ClosedPublic
Actions

Authored by inka on Jan 12 2024, 7:30 AM.
Tags
None
Referenced Files
F3350132: D10620.id35770.diff
Fri, Nov 22, 8:53 PM
F3349088: D10620.diff
Fri, Nov 22, 5:05 PM
Unknown Object (File)
Fri, Nov 8, 11:05 PM
Unknown Object (File)
Thu, Nov 7, 5:36 AM
Unknown Object (File)
Tue, Nov 5, 7:17 PM
Unknown Object (File)
Tue, Nov 5, 4:17 PM
Unknown Object (File)
Tue, Nov 5, 4:10 PM
Unknown Object (File)
Tue, Nov 5, 1:25 PM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
ashoat
Commits
rCOMM4160b885c356: [lib] Refactor thread reducer
Summary

issue: ENG-5814
We want to remove the thread related to the ks the user has logged in to / logged out of / had the cookie invalidated by.

Test Plan

Tested that when keyserverAuthActionTypes.success is dispatched the threads are deleted and replaced with the new ones
Checked that when a user logs out the threads are deleted.

Diff Detail

Repository
rCOMM Comm
Branch
inka/login_reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 12 2024, 7:30 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 12 2024, 7:30 AM
inka added a parent revision: D10619: [lib] Refactor report store reducer.Jan 12 2024, 7:31 AM
Harbormaster completed remote builds in B25727: Diff 35576.Jan 12 2024, 8:18 AM
inka requested review of this revision.Jan 12 2024, 8:18 AM
ashoat added inline comments.Jan 13 2024, 6:06 PM
lib/shared/thread-utils.js
1807

Should this be in lib/keyserver-conn/keyserver-call-utils.js?

inka updated this revision to Diff 35604.Jan 15 2024, 1:52 AM

Move function

Harbormaster failed remote builds in B25753: Diff 35604!Jan 15 2024, 2:04 AM
inka added a child revision: D10628: [lib] Refactor user reducer.Jan 15 2024, 3:28 AM
ashoat accepted this revision.Jan 15 2024, 4:45 PM

Thanks for moving it! The name of the file is kind of weird given the use case here, but the family of functions there is very similar... I think it's good they're in the same file, and we might consider moving / renaming the file in a later diff

This revision is now accepted and ready to land.Jan 15 2024, 4:45 PM
inka planned changes to this revision.Jan 17 2024, 8:51 AM

We decided to have a single action for logging out of keyservers and identity.

inka updated this revision to Diff 35770.Jan 18 2024, 1:41 AM

Undo changes to logout

This revision is now accepted and ready to land.Jan 18 2024, 1:41 AM
inka requested review of this revision.Jan 18 2024, 1:41 AM
Harbormaster completed remote builds in B25875: Diff 35770.Jan 18 2024, 2:08 AM
ashoat accepted this revision.Jan 21 2024, 9:43 PM
This revision is now accepted and ready to land.Jan 21 2024, 9:43 PM
inka updated this revision to Diff 35922.Jan 22 2024, 3:15 AM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B25990: Diff 35922.Jan 22 2024, 3:43 AM
inka updated this revision to Diff 36023.Jan 23 2024, 1:37 AM

Following D10609, make threadInfos in KeyserverAuthResult be RawThreadInfos

Harbormaster completed remote builds in B26069: Diff 36023.Jan 23 2024, 2:06 AM
Closed by commit rCOMM4160b885c356: [lib] Refactor thread reducer (authored by inka). · Explain WhyJan 29 2024, 8:41 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM4160b885c356: [lib] Refactor thread reducer.

Revision Contents
Changeset List

PathSize
lib/
reducers/
76 lines
shared/
15 lines
39 lines

Diff 35576

View Options

lib/reducers/thread-reducer.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...