Page MenuHomePhabricator

[lib] Remove threads from calendar filters on logout
ClosedPublic

Authored by inka on Jan 16 2024, 1:21 AM.
Tags
None
Referenced Files
F3573382: D10647.diff
Sat, Dec 28, 2:32 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Sun, Dec 22, 2:48 PM
Subscribers

Details

Summary

issue: ENG-5988
We want to remove all ids of threads that belong to the keyserver the user is logging out of.
IT'S VERY IMPORTANT THAT THE CURRENT BEHAVIOUR STAYS AS IS FOR USERS NOT USING CSAT. It will be the case for all diffs in this stack. Logout / delete account actions will not be replaced like login was, so we are using the same action types and hiding the old logic behind the flag.

Test Plan

Tested that if the user logs out and usingCommServicesAccessToken === true then threads that belong to the keyserver the user is logging out of are deleted. Tested that if usingCommServicesAccessToken === false, then filters are set to default values

Diff Detail

Repository
rCOMM Comm
Branch
inka/login_reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 16 2024, 1:31 AM
Harbormaster failed remote builds in B25787: Diff 35650!
inka requested review of this revision.Jan 16 2024, 1:53 AM
lib/reducers/calendar-filters-reducer.js
67

I proposed on Linear earlier that we continue using logOutActionTypes for global app-wide logout (including identity logout and keyserver logout). If we do that, should we keep the old logic for logOutActionTypes.success, even if usingCommServicesAccessToken?

lib/reducers/calendar-query-reducer.js
28

Same question here

inka planned changes to this revision.Jan 17 2024, 8:18 AM

We decided to have a single action for logging out of keyservers and identity.

inka edited the summary of this revision. (Show Details)

Undo changes to logout

Same question as here

lib/reducers/calendar-filters-reducer.js
68–70 ↗(On Diff #35773)

Why are these lines necessary?

lib/reducers/calendar-query-reducer.js
34–36 ↗(On Diff #35773)

Why are these lines necessary?

Merge identity delete account with keyserver delete account

Updated according to this discussion - we want to have a singe action for deleting identity account and keyserver accounts, and an action for deleting just a keyserver account (for when the user disconnects from a keyserver)

I think the diff description stopped matching the changes.

This revision is now accepted and ready to land.Jan 25 2024, 6:01 AM