lib] Refactor message reducer
ClosedPublic
Actions

Authored by inka on Jan 16 2024, 7:42 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM581f71cd93ec: lib] Refactor message reducer

Summary

issue: ENG-5766
MessageStore looks like this:

export type MessageStore = {
  +messages: { +[id: string]: RawMessageInfo },
  +threads: MessageStoreThreads,
  +local: { +[id: string]: LocalMessageInfo },
  +currentAsOf: { +[keyserverID: string]: number },
};

messages, local and threads are filtered by updateMessageStoreWithLatestThreadInfos/processMessageStoreOperations based on what threads were removed by thread reducer. I only need to update currentAsOf.

Test Plan

Tested that if a user logs out of one keyserver all data related to this keyserver is wiped from MessageStore

Diff Detail

Repository

rCOMM Comm

Branch

inka/login_reducers

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jan 16 2024, 7:42 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 16 2024, 7:42 AM

inka added a parent revision: D10652: [lib] Fix currentAsOf.Jan 16 2024, 7:43 AM

Harbormaster completed remote builds in B25803: Diff 35674.Jan 16 2024, 8:01 AM

inka requested review of this revision.Jan 16 2024, 8:01 AM

ashoat added inline comments.Jan 16 2024, 6:59 PM

lib/reducers/message-reducer.js
853	As mentioned in other diffs, I'm not sure if we need to change anything for `logOutActionTypes.success`

inka edited parent revisions, added: D10650: [lib] Refactor logout in reduceEntryInfos; removed: D10652: [lib] Fix currentAsOf.Jan 17 2024, 1:05 AM

inka added a parent revision: D10652: [lib] Fix currentAsOf.

inka added a child revision: D10658: [lib] Refactor logout in keyserver reducer.Jan 17 2024, 5:37 AM

inka added a comment.Jan 17 2024, 8:16 AM

This comment was removed by inka.

We decided to have a single action for logging out of keyservers and identity.

Because we decided to merge logout from keyservers with logout from identity, all keyservers will be removed on logut, so we want to remove them all from currenAsOf. In case of deleteKeyserverAccountActionTypes action.payload.keyserverIDs will be defined, so we will only remove those keyservers.
I tested that the fact that we are removing ashoats keyserver from currenAsOf doesn't break anything - when the user logs out and back in, the value gets set without any errors

Harbormaster completed remote builds in B25882: Diff 35777.Jan 18 2024, 3:05 AM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B26007: Diff 35940.Jan 22 2024, 4:25 AM

michal accepted this revision.Jan 29 2024, 5:40 AM

This revision is now accepted and ready to land.Jan 29 2024, 5:40 AM

michal added inline comments.Jan 29 2024, 5:42 AM

lib/reducers/message-reducer.js
886 ↗	(On Diff #35940)	Maybe it would be better to do this check again? If someone adds `keyserverIDs` to another action in the future, they might be suprised that this code will run