Page MenuHomePhabricator
Differential D10661

[lib] Refactor logout in thread activity reducer
ClosedPublic
Actions

Authored by inka on Jan 17 2024, 6:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 11:10 AM
Unknown Object (File)
Wed, Mar 19, 6:52 PM
Unknown Object (File)
Tue, Mar 18, 9:03 AM
Unknown Object (File)
Tue, Mar 11, 3:56 PM
Unknown Object (File)
Tue, Mar 11, 3:54 PM
Unknown Object (File)
Tue, Mar 11, 3:52 PM
Unknown Object (File)
Sun, Mar 2, 10:12 AM
Unknown Object (File)
Sat, Mar 1, 10:31 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer
Summary

issue: ENG-5827
We want to remove only the threads related to the keyservers the user is disconnecting from

Test Plan

Ran the provided test

Diff Detail

Repository
rCOMM Comm
Branch
inka/login_reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 17 2024, 6:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 17 2024, 6:57 AM
inka added a parent revision: D10659: [lib] Refactor logout in invite links reducer.Jan 17 2024, 6:57 AM

We are discussing in ENG-6424 if logout should be refactored, but delete account has to be refactored anyway

Harbormaster completed remote builds in B25834: Diff 35723.Jan 17 2024, 7:15 AM
inka requested review of this revision.Jan 17 2024, 7:15 AM
inka planned changes to this revision.Jan 17 2024, 8:14 AM

We decided to have a single action for logging out of keyservers and identity.

inka updated this revision to Diff 35780.Jan 18 2024, 2:52 AM

Undo changes to logout

Harbormaster completed remote builds in B25885: Diff 35780.Jan 18 2024, 3:10 AM
inka updated this revision to Diff 35943.Jan 22 2024, 4:06 AM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B26010: Diff 35943.Jan 22 2024, 4:35 AM
michal accepted this revision.Jan 29 2024, 7:23 AM
This revision is now accepted and ready to land.Jan 29 2024, 7:23 AM
inka added a child revision: D10778: [web] Handle invalid session downgrade for identity delete account.Jan 29 2024, 7:53 AM
Closed by commit rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer (authored by inka). · Explain WhyJan 29 2024, 8:42 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer.

Revision Contents
Changeset List

Diff 35723

View Options

lib/reducers/thread-activity-reducer.js

fn main() { use futures_core::Stream;
println!("Hello, world!"); use std::pin::Pin;
use tonic::{transport::Server, Request, Response, Status};
use identity::identity_service_server::{IdentityService, IdentityServiceServer};
use identity::{
GetUserTokenRequest, GetUserTokenResponse, LoginRequest, LoginResponse, RegistrationRequest,
RegistrationResponse,
};
pub mod identity {
tonic::include_proto!("identity");
}
#[derive(Debug, Default)]
pub struct MyIdentityService {}
#[tonic::async_trait]
impl IdentityService for MyIdentityService {
type RegisterUserStream =
Pin<Box<dyn Stream<Item = Result<RegistrationResponse, Status>> + Send + 'static>>;
async fn register_user(
&self,
request: Request<tonic::Streaming<RegistrationRequest>>,
) -> Result<Response<Self::RegisterUserStream>, Status> {
println!("Got a registration request: {:?}", request);
unimplemented!()
}
type LoginUserStream =
Pin<Box<dyn Stream<Item = Result<LoginResponse, Status>> + Send + 'static>>;
async fn login_user(
&self,
request: Request<tonic::Streaming<LoginRequest>>,
) -> Result<Response<Self::LoginUserStream>, Status> {
println!("Got a login request: {:?}", request);
unimplemented!()
}
async fn get_user_token(
&self,
request: Request<GetUserTokenRequest>,
) -> Result<Response<GetUserTokenResponse>, Status> {
println!("Got a lookup request: {:?}", request);
unimplemented!()
}
}
#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
let addr = "[::]:50054".parse()?;
let identity_service = MyIdentityService::default();
Server::builder()
.add_service(IdentityServiceServer::new(identity_service))
.serve(addr)
.await?;
Ok(())
} }
View Options

lib/reducers/thread-activity-reducer.test.js

fn main() { use futures_core::Stream;
println!("Hello, world!"); use std::pin::Pin;
use tonic::{transport::Server, Request, Response, Status};
use identity::identity_service_server::{IdentityService, IdentityServiceServer};
use identity::{
GetUserTokenRequest, GetUserTokenResponse, LoginRequest, LoginResponse, RegistrationRequest,
RegistrationResponse,
};
pub mod identity {
tonic::include_proto!("identity");
}
#[derive(Debug, Default)]
pub struct MyIdentityService {}
#[tonic::async_trait]
impl IdentityService for MyIdentityService {
type RegisterUserStream =
Pin<Box<dyn Stream<Item = Result<RegistrationResponse, Status>> + Send + 'static>>;
async fn register_user(
&self,
request: Request<tonic::Streaming<RegistrationRequest>>,
) -> Result<Response<Self::RegisterUserStream>, Status> {
println!("Got a registration request: {:?}", request);
unimplemented!()
}
type LoginUserStream =
Pin<Box<dyn Stream<Item = Result<LoginResponse, Status>> + Send + 'static>>;
async fn login_user(
&self,
request: Request<tonic::Streaming<LoginRequest>>,
) -> Result<Response<Self::LoginUserStream>, Status> {
println!("Got a login request: {:?}", request);
unimplemented!()
}
async fn get_user_token(
&self,
request: Request<GetUserTokenRequest>,
) -> Result<Response<GetUserTokenResponse>, Status> {
println!("Got a lookup request: {:?}", request);
unimplemented!()
}
}
#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
let addr = "[::]:50054".parse()?;
let identity_service = MyIdentityService::default();
Server::builder()
.add_service(IdentityServiceServer::new(identity_service))
.serve(addr)
.await?;
Ok(())
} }