Paths

Table of Contentst

Differential D10650

[lib] Refactor logout in reduceEntryInfos
ClosedPublic
Actions

Authored by inka on Jan 16 2024, 6:01 AM.

Tags

None

Referenced Files

	F3388264: D10650.id35776.diff
	Fri, Nov 29, 1:26 PM

	Unknown Object (File)
	Tue, Nov 26, 3:50 AM

	Unknown Object (File)
	Tue, Nov 26, 3:41 AM

	Unknown Object (File)
	Tue, Nov 26, 3:26 AM

	Unknown Object (File)
	Tue, Nov 26, 1:40 AM

	Unknown Object (File)
	Wed, Nov 6, 1:15 PM

	Unknown Object (File)
	Oct 16 2024, 1:56 AM

	Unknown Object (File)
	Oct 16 2024, 1:56 AM

View All 87 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM2ffa6b79192d: [lib] Refactor logout in reduceEntryInfos

Summary

issue: ENG-5766
We don't want to remove lastUserInteractionCalendar for users using CSAT.
The rest of the reducer is already correct, because it checks new threads aand based on that removes entries. So if thread reducer removes threads related to the keyserver, the entires will be removed as well

Test Plan

Tested that if a user is connected to another keyserver and logs out of it, the corresponding entires are indeed removed. Tested that for a user not using CSAT, lastUserInteractionCalendar is still reset to 0

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 16 2024, 6:01 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 16 2024, 6:01 AM

inka added a parent revision: D10649: [lib] Stop removing policies on keyserver logout.Jan 16 2024, 6:02 AM

Harbormaster completed remote builds in B25797: Diff 35666.Jan 16 2024, 6:19 AM

inka requested review of this revision.Jan 16 2024, 6:19 AM

inka added a child revision: D10652: [lib] Fix currentAsOf.Jan 16 2024, 6:50 AM

As mentioned in other diffs, not sure if we need to chnage anything for logOutActionTypes.success

inka added a child revision: D10653: lib] Refactor message reducer.Jan 17 2024, 1:05 AM

inka removed a child revision: D10652: [lib] Fix currentAsOf.

We decided to have a single action for identity and ks logout

Undo changes to logout

Harbormaster completed remote builds in B25881: Diff 35776.Jan 18 2024, 2:41 AM

ashoat added inline comments.Jan 20 2024, 8:36 PM

lib/reducers/entry-reducer.js
184–185 ↗	(On Diff #35776)	Same question as here

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B26006: Diff 35938.Jan 22 2024, 4:33 AM

michal accepted this revision.Jan 25 2024, 6:25 AM

This revision is now accepted and ready to land.Jan 25 2024, 6:25 AM

Closed by commit rCOMM2ffa6b79192d: [lib] Refactor logout in reduceEntryInfos (authored by inka). · Explain WhyJan 29 2024, 8:42 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM2ffa6b79192d: [lib] Refactor logout in reduceEntryInfos.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

entry-reducer.js

13 lines

Diff 36282

lib/reducers/entry-reducer.js

Loading...