Details
Will set breakpoints and observe that the shape of data is as expected at each step of the migration.
Will also inspect SQLite DB directly before/after to make sure that things are encoded as expected.
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
EDIT: Will go ahead and write the migration. The previous time all staff had logged out/back in for another reason as a coincidence so it wasn't necessary, but migration will be less disruptive than asking staff to re-auth.
What is the downside of making this diff a draft instead of marking its title with a label?
Yes, a draft is visible and can be linked and accessed just like a normal diff. The only difference is that it doesn't appear in any queue.
Will avoid [DRAFT] in commit name in future and write something more specific in Summary instead.
I think it is OK to have a diff that shows e.g. the usage. My concern was about the fact that the diff was appearing in a couple of queues without any need - it wasn't actionable.
native/redux/persist.js | ||
---|---|---|
1158 | Shouldn't this version be bumped? |
native/redux/persist.js | ||
---|---|---|
1158 | It'll be bumped along with web migration, codeVersion bump, and keyserver deploy |